Thank you for your interest in contributing to TypeScript ESLint! 💜
Make sure you read our Code of Conduct before contributing.
So you've got a bug report, documentation request, or feature suggestion? Great!
Do:
- Make sure you're using the latest version of our packages
- Search all opened and closed issues to make sure your issue wouldn't be a duplicate
- Fill out the appropriate issue template completely
- Provide as much information as you can
We do not have the bandwidth to handle questions or support requests in the issue tracker. You can instead:
- Ask a question on StackOverflow using the
typescript-eslinttag - Publicly tweet @tseslint on Twitter
Note that requests to add documentation are allowed, even encouraged! 📝
Please do comment on any open issue if you have more information that would be useful.
Don't:
- Leave useless comments such as "+1" or "when's this getting fixed?" that only act as spam
- If you have nothing to add but enthusiasm and joy, add a reaction such as 👍
- Bring up unrelated topics in existing issues: instead, file a new issue
- Comment on closed PRs: instead, file a new issue
- Comment on commits directly, as those comments are not searchable: instead, file a new issue
See DEVELOPMENT.md for details on how to get started developing locally.
Do:
- Only send pull requests that resolve open issues marked as
accepting prs- One exception: extremely minor documentation typos
- Fill out the pull request template in full
- Validate your changes per Development > Validating Changes before un-drafting your PR
Don't:
- Force push after opening a PR
- Reasoning: GitHub is not able to track changes across force pushes, which makes it take longer for us to perform incremental reviews
- Comment asking for updates
- Reasoning: Your PR hasn't been forgotten! The volunteer maintainers have limited time to work on the project, and they will get to it as soon as they are able.
Once your changes are ready, you can raise a PR! 🙌 The title of your PR should match the following format:
<type>(<package>): <short description>
You can find more samples of good past PR titles in recent commits to main.
fix(scope-manager): correct handling for class static blocks
docs: Fix links to getting started in README.md
Within the body of your PR, make sure you reference the issue that you have worked on, as well as pointing out anything of note you wish us to look at during our review.
We do not care about the number, or style of commits in your history, because we squash merge every PR into
main. Feel free to commit in whatever style you feel comfortable with.
Must be one of the following:
docs- if you only change documentation, and not shipped codefeat- for any new functionality additionsfix- for any bug fixes that don't add new functionalitytest- if you only change tests, and not shipped codechore- anything else
The name of the package you have made changes within, (e.g. eslint-plugin, parser, typescript-estree).
If you make significant changes across multiple packages, you can omit this (e.g.
feat: foo bar).
A succinct title for the PR.
With your PR raised and the CI passing, your PR will wait in the queue to be reviewed. We generally review PRs oldest to newest, unless we consider a newer PR higher priority (e.g. if it's a bug fix).
Once we have reviewed your PR, we will provide any feedback that needs addressing.
If you feel a requested change is wrong, don't be afraid to discuss with us in the comments.
Once the feedback is addressed, and the PR is reviewed, we'll ensure the branch is up to date with main, and merge it for you.