Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Although supporting this was a neat idea, this change now requires that I delete the version from any entity I loaded from the database before saving it. #9218

Closed
acuthbert opened this issue Jul 19, 2022 · 0 comments

Comments

@acuthbert
Copy link
Contributor

Although supporting this was a neat idea, this change now requires that I delete the version from any entity I loaded from the database before saving it.

Which by itself isn't that big of a deal, except in the case where I'm saving an entity without having updated any other fields (from a client request), save() skips the update as it should, which is fine except the same entity with the version removed gets returned.

This can lead to all sort of issues since you expect the entity returned by save() to always represent the information that's in the database.

So now to get the same behavior as before I practically have to re-implement the same mechanism as save() and check if the object was modified before deleting the version from the object and calling save()...

Originally posted by @Malbeth81 in #3271 (comment)

@acuthbert acuthbert closed this as not planned Won't fix, can't repro, duplicate, stale Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant