fix: don't use temporary table name to create foreign key, unique, check constraint with SQLite #9185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eck constraint with SQLite In migration steps, finally temporary table name is renamed to original table name. these constraints name should be created from original table name not temporary table name. Closes: typeorm#9176
|
@AlexMesser can you review it, please? |
AlexMesser
approved these changes
Aug 24, 2022
|
thank you for contribution! |
wirekang
pushed a commit
to wirekang/typeorm
that referenced
this pull request
Aug 25, 2022
…eck constraint with SQLite (typeorm#9185) * fix: don't use temporary table name to create foreign key, unique, check constraint with SQLite In migration steps, finally temporary table name is renamed to original table name. these constraints name should be created from original table name not temporary table name. Closes: typeorm#9176 * style: remove unnecessary comment
nordinh
pushed a commit
to nordinh/typeorm
that referenced
this pull request
Aug 29, 2022
…eck constraint with SQLite (typeorm#9185) * fix: don't use temporary table name to create foreign key, unique, check constraint with SQLite In migration steps, finally temporary table name is renamed to original table name. these constraints name should be created from original table name not temporary table name. Closes: typeorm#9176 * style: remove unnecessary comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
In migration steps, finally temporary table name is renamed to original table name. these constraints name should be created from original table name not temporary table name.
Fixes #9176
Pull-Request Checklist
masterbranchnpm run formatto apply prettier formattingnpm run testpasses with this changeFixes #9176