fix: resolve FindOptionsOrder.nulls to allow FIRST/LAST in uppercase #8978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahmedosama94
changed the title
ahmedosama94
force-pushed
the
8970-find-options-order-nulls-first-and-last
branch
from
7c56c46
to
eebc0bf
Compare
ahmedosama94
force-pushed
the
8970-find-options-order-nulls-first-and-last
branch
from
eebc0bf
to
19cb8b3
Compare
|
tests are failing... |
|
@pleerock I'm aware, I did not get the chance to get back this yet unfortunately. But I will get to it. |
|
thank you for contribution! |
nordinh
pushed a commit
to nordinh/typeorm
that referenced
this pull request
Aug 29, 2022
…ypeorm#8978) * fix: resolve FindOptionsOrder.nulls issue to accept FIRST/LAST in uppercase Closes typeorm#8970 * fixed failing test Co-authored-by: Alex Messer <dmzt08@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8970
Description of change
Resolved a minor issue where uppercased
"FIRST"option forFindOptionsOrder.nullswas being ignored. Similarly for"LAST"Pull-Request Checklist
masterbranchnpm run formatto apply prettier formattingnpm run testpasses with this changeFixes #0000