You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
sqlite migrations must re-create tables when doing most changes. These temporary tables don't honor withoutRowid
Expected Behavior
I expect the new temporary_ to honor any special options that exist for sqlite in the EntityMetadata
Actual Behavior
Original tables are created properly with WITHOUT ROWID but the new temporary tables don't receive this info because there's no table in EntityMetadata that matches this temporary prefixed name.
Steps to Reproduce
Create Entity with withoutRowid: true as an option.
Attempt to generate migration.
Notice that none of the temporary table create statements have a trailing "WITHOUT ROWID" even though the original create table statements do.
Relevant Database Driver(s)
DB Type
Reproducible
aurora-data-api
no
aurora-data-api-pg
no
better-sqlite3
no
cockroachdb
no
cordova
no
expo
no
mongodb
no
mysql
no
nativescript
no
oracle
no
postgres
no
react-native
no
sap
no
sqlite
yes
sqlite-abstract
yes
sqljs
no
sqlserver
no
Are you willing to resolve this issue by submitting a Pull Request?
✅ Yes, I have the time, and I know how to start.
✖️ Yes, I have the time, but I don't know how to start. I would need guidance.
✖️ No, I don’t have the time, but I can support (using donations) development.
✖️ No, I don’t have the time and I’m okay to wait for the community / maintainers to resolve this issue.
PR is complete. Just running tests, will submit shortly. :-)
The text was updated successfully, but these errors were encountered:
Issue Description
sqlite migrations must re-create tables when doing most changes. These temporary tables don't honor
withoutRowid
Expected Behavior
I expect the new
temporary_
to honor any special options that exist for sqlite in theEntityMetadata
Actual Behavior
Original tables are created properly with
WITHOUT ROWID
but the new temporary tables don't receive this info because there's no table inEntityMetadata
that matches this temporary prefixed name.Steps to Reproduce
Entity
withwithoutRowid: true
as an option.Relevant Database Driver(s)
aurora-data-api
aurora-data-api-pg
better-sqlite3
cockroachdb
cordova
expo
mongodb
mysql
nativescript
oracle
postgres
react-native
sap
sqlite
sqlite-abstract
sqljs
sqlserver
Are you willing to resolve this issue by submitting a Pull Request?
PR is complete. Just running tests, will submit shortly. :-)
The text was updated successfully, but these errors were encountered: