Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

django-stubs-ext version schema #1409

Closed
christianbundy opened this issue Mar 21, 2023 · 4 comments · Fixed by #1458
Closed

django-stubs-ext version schema #1409

christianbundy opened this issue Mar 21, 2023 · 4 comments · Fixed by #1458
Labels
bug Something isn't working meta Meta-issues and discussion

Comments

@christianbundy
Copy link
Contributor

Bug report

What's wrong

I want to automatically update to newer versions of libraries, and so I use a version specifier like ~=1.0 to upgrade to versions 1.x.x, hoping that dependencies follow semver. When the version starts with 0, I need to use ~=0.1.0 to upgrade to all 0.1.x versions because semver defines bumping the minor version (i.e. 0.2.0) as a breaking change.

I think django-stubs follows this, at least in spirit, but django-stubs-ext only bumps the minor version: https://pypi.org/project/django-stubs-ext/#history

How is that should be

I would love for django-stubs-ext to either:

  • Bump the patch release for mostly-backward-compatible changes (similar to how django-stubs bumps the minor version), or
  • My preference: bump the major version to 1 to match django-stubs and continue bumping the minor version the way we have been

System information

N/A

@christianbundy christianbundy added the bug Something isn't working label Mar 21, 2023
@intgr intgr added the meta Meta-issues and discussion label Mar 21, 2023
@intgr
Copy link
Collaborator

intgr commented Mar 21, 2023

I think there's no particular reason why we're still using 0.x versions for django-stubs-ext? @sobolevn?

We should release django-stubs-ext 1.0.0 next time around.

@sobolevn
Copy link
Member

I think we can release the same version as django has.

Basically like django-major.django-minor.our-own-patch

@sobolevn
Copy link
Member

And we can only claim to support this version. Other versions can be "partially supported".

@intgr
Copy link
Collaborator

intgr commented Mar 21, 2023

Oh, right, we already had this discussion at #1095 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working meta Meta-issues and discussion
Development

Successfully merging a pull request may close this issue.

3 participants