Type hint improvements for string promises, manager, query set #1272
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I originally dove in to address issues where type hints only accepted
str
but should accept_StrOrPromise | None
, so there are two commits about that.One commit changes the hints in the signatures of
django.db.models.query._QuerySet.as_manager()
anddjango.db.models.manager.BaseManager.from_queryset()
to use generics/typevars instead ofAny
.Finally, I found two places with what I think are unnecessary
# type: ignore
comments.Let me know if you have any feedback or questions. Thanks!