Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 1.13.1 release #1241

Merged
merged 3 commits into from Dec 8, 2022
Merged

Version 1.13.1 release #1241

merged 3 commits into from Dec 8, 2022

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Nov 8, 2022

Let's hope that it will work!

@intgr
Copy link
Collaborator

intgr commented Nov 8, 2022

Wow looks like there are other issues with mypy 0.990 https://github.com/typeddjango/django-stubs/actions/runs/3421536321/jobs/5697823439#step:6:462

For the pytest tests you can add show_error_codes = False to mypy configuration, that should fix many of the diffs.

requirements.txt Outdated
@@ -9,4 +9,4 @@ psycopg2-binary
-e .[compatible-mypy]

# Overrides:
mypy==0.982
mypy==0.990
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless mypy 0.991 solves the issues we're having, IMO we can make a release that's being tested with mypy==0.982.

Having a release that solves some mypy 0.99x problems is better than delaying the release.

Of course having full support for latest mypy would be ideal, but right now I don't have time and interest to look into the CI failures.

@intgr
Copy link
Collaborator

intgr commented Nov 15, 2022

I opened bug #1261 about the plugin internal error with mypy 0.99x.

Let's defer mypy update for now and make a release anyway?

@intgr intgr mentioned this pull request Dec 8, 2022
@sobolevn sobolevn closed this Dec 8, 2022
@sobolevn sobolevn reopened this Dec 8, 2022
@sobolevn sobolevn merged commit 090aea6 into master Dec 8, 2022
@sobolevn sobolevn deleted the version-1.13.1 branch December 8, 2022 09:06
@sobolevn
Copy link
Member Author

sobolevn commented Dec 8, 2022

@intgr would you like to do the release? :)

@intgr
Copy link
Collaborator

intgr commented Dec 8, 2022

Sure, I can give it a shot. What are the exact commands I should run; is there documentation somewhere?

@sobolevn
Copy link
Member Author

sobolevn commented Dec 8, 2022

https://github.com/typeddjango/django-stubs/blob/master/scripts/release.sh

@sobolevn
Copy link
Member Author

sobolevn commented Dec 8, 2022

Plus git tag

@intgr
Copy link
Collaborator

intgr commented Dec 8, 2022

Looks like I may have done it 😮

I will clean up the autogenerated release notes soon.

@sobolevn
Copy link
Member Author

sobolevn commented Dec 8, 2022

Congrats 🎉

@intgr intgr mentioned this pull request Jan 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants