Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Octane and much polish and clarification #935

Merged
merged 131 commits into from
Dec 22, 2020
Merged

Conversation

chriskrycho
Copy link
Member

@chriskrycho chriskrycho commented Nov 6, 2019

This now migrates everything to GitBook, and covers both Octane and Classic. This is not exhaustive, but it is a reasonable starting point, and we can iterate from here.

@chriskrycho
Copy link
Member Author

@dfreeman not sure why but we doesn't appear to be deploying this correctly (or possibly we have a caching issue). I can try to take a peek, but probably not till Monday. It's reporting latest published as 079a848 – when you merged master into this branch – and not picking up anything newer. 🤔

@dfreeman
Copy link
Member

dfreeman commented Dec 6, 2019

🤦‍♂ The commits are all there, but apparently there's a known issue where specifically for public repos a commit coming from an action won't trigger a Pages build: https://github.community/t5/GitHub-Actions/Github-action-not-triggering-gh-pages-upon-push/td-p/26869

I'll see if I can come up with a workaround, but for now running ember deploy production locally when you want to refresh may be the simplest path forward.

@chriskrycho
Copy link
Member Author

Whaaaaaaaat.

Deploy manually it is!

@chriskrycho
Copy link
Member Author

I've updated and added a bunch of material and redeployed! (I have not yet integrated the suggestions above b/c my focus was on getting a bunch of the organization in place.)

- change a list to a paragraph
- improve the description of tradeoffs around approachs
@chriskrycho chriskrycho changed the title docs: Octane and much polish and clarification [WIP] docs: Octane and much polish and clarification Dec 19, 2020
@chriskrycho
Copy link
Member Author

@dfreeman @jamescdavis at this point, I think there's more value in getting these into the world than in thinking about trying to polish further first. They're already a year late. Better to get them up and then iterate on something and that way better serve end users. Assuming no 👎🏼 from either of you, I'll plan to merge this over the weekend and then we can keep making forward progress. We'll also need to coordinate getting the custom domain rejiggered for it, but that should be pretty easy.

@chriskrycho chriskrycho added this to In progress in Octane docs push! via automation Dec 19, 2020
@chriskrycho chriskrycho moved this from In progress to Review in progress in Octane docs push! Dec 19, 2020
@jamescdavis
Copy link
Member

Agreed! LMK when we're ready to cut over and I'll repoint the domain.

@chriskrycho chriskrycho merged commit 0d760c2 into master Dec 22, 2020
Octane docs push! automation moved this from Review in progress to Done Dec 22, 2020
@chriskrycho chriskrycho deleted the octane-docs branch December 22, 2020 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants