Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix qunit types... again #1401

Merged
merged 1 commit into from
Feb 4, 2021
Merged

Fix qunit types... again #1401

merged 1 commit into from
Feb 4, 2021

Conversation

jamescdavis
Copy link
Member

This bumps @types/qunit and yarn-deduplicates to resolve the failing floating dependency tests... again.

chriskrycho
chriskrycho approved these changes Feb 4, 2021
View reviewed changes
Copy link
Member

@chriskrycho chriskrycho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And so it will forever. «sigh»

@chriskrycho chriskrycho merged commit 7098f98 into master Feb 4, 2021
@chriskrycho chriskrycho deleted the fix_qunit_types_again branch February 4, 2021 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chriskrycho chriskrycho chriskrycho approved these changes

@dfreeman dfreeman Awaiting requested review from dfreeman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jamescdavis @chriskrycho