Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove reliance on a package-level wordlist #12

Open
tyler-smith opened this issue Jul 12, 2018 · 1 comment
Open

Remove reliance on a package-level wordlist #12

tyler-smith opened this issue Jul 12, 2018 · 1 comment
Assignees
@tyler-smith
Labels
enhancement
Projects
V2
Milestone
2.0

Comments

@tyler-smith
Copy link
Owner

Currently there are package level variables holding the wordlist to use. This is not ideal because it makes using the library with multiple languages difficult.

I've started an attempt at a v2 of this lib that creates an Encoder type that encapsulates the wordlist. Encoders for each built-in language are provided. Package-root level functions that proxy to the English Encoder are provided.

https://github.com/tyler-smith/go-bip39/tree/TS_v2

Please give feedback/thoughts on this approach.
@tyler-smith tyler-smith self-assigned this Jul 12, 2018
@tyler-smith tyler-smith added this to the 2.0 milestone Jul 12, 2018
@tyler-smith tyler-smith added this to In progress in V2 Jul 16, 2018
@tyler-smith tyler-smith mentioned this issue Oct 17, 2018
Closed
@gz-c
Copy link

gz-c commented Feb 25, 2019

The approach looks good, was there anything you were unsure on?

@tyler-smith tyler-smith moved this from In progress to Done in V2 Oct 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tyler-smith tyler-smith

Labels
enhancement
Projects
V2
  
Done
Milestone
2.0
Development

No branches or pull requests
2 participants
@tyler-smith @gz-c