Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please allow minor version updates for 'underscore' dependency #60

Closed
ttc229 opened this issue Apr 23, 2021 · 3 comments
Closed

Please allow minor version updates for 'underscore' dependency #60

ttc229 opened this issue Apr 23, 2021 · 3 comments

Comments

@ttc229
Copy link
Contributor

ttc229 commented Apr 23, 2021

Our project flagged a Security Vulnerability in the underscore dependency jashkenas/underscore#2915 which is hoisted via spritesheet-templates.

The current package.json uses "underscore": "~1.4.2". The fix for the underscore vulnerability is in versions 1.12.1,1.13.0-2.

The semantic versioning allows us to upgrade patch versions but for this particular fix, we will need a minor version upgrade to get to 1.13.1

Is it possible to change this dependency to "underscore": "^1.4.2" to allow minor version upgrades as well?
@twolfson
Copy link
Owner

I prefer to stick to ~ because some libraries have introduced breaking changes in minor upgrades =/

That being said, I'll gladly accept a PR to bump vulnerable dependencies at any time =)

@ttc229
Copy link
Contributor Author

ttc229 commented Apr 26, 2021

Added Pull Request #61

@twolfson
Copy link
Owner

This has been patched and released via #61 in 10.5.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@twolfson @ttc229