{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":1007362,"defaultBranch":"develop","name":"finagle","ownerLogin":"twitter","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2010-10-19T22:10:09.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/50278?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1715037083.0","currentOid":""},"activityList":{"items":[{"before":"cc9e3dfa3440a105a53464511bc2a8f8e2b07733","after":"7111467b155b75591726c704a388623187580204","ref":"refs/heads/develop","pushedAt":"2024-05-07T20:17:55.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"finaglehelper","name":"BB-8","path":"/finaglehelper","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/17730895?s=80&v=4"},"commit":{"message":"Twitter-oss: update OSS libraries post-release to 24.8.0-SNAPSHOT\n\nProblem\n\nWe want to update to the next SNAPSHOT version of our Twitter OSS libraries 24.8.0-SNAPSHOT\n - util\n - scrooge\n - finagle\n - twitter-server\n - finatra\n\nSolution\n\nPrepare libraries for their next SNAPSHOT version.\n\nDifferential Revision: https://phabricator.twitter.biz/D1141538","shortMessageHtmlLink":"Twitter-oss: update OSS libraries post-release to 24.8.0-SNAPSHOT"}},{"before":"ea9908683c8ca0f61b63f7cffe4166029e4b9e9b","after":"cc9e3dfa3440a105a53464511bc2a8f8e2b07733","ref":"refs/heads/release","pushedAt":"2024-05-06T23:11:24.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"finaglehelper","name":"BB-8","path":"/finaglehelper","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/17730895?s=80&v=4"},"commit":{"message":"Twitter-oss: Prepare OSS libraries for release 24.5.0\n\nProblem\n\nWe want to release the next versions of our Twitter OSS libraries 24.5.0\n\nutil\nscrooge\nfinagle\ntwitter-server\nfinatra\nSolution\n\nPrepare libraries for their next releases.\n\nDifferential Revision: https://phabricator.twitter.biz/D1141504","shortMessageHtmlLink":"Twitter-oss: Prepare OSS libraries for release 24.5.0"}},{"before":"768d5594dd95824c0f8d040e148a3d193c59880d","after":"cc9e3dfa3440a105a53464511bc2a8f8e2b07733","ref":"refs/heads/develop","pushedAt":"2024-05-06T21:11:52.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"finaglehelper","name":"BB-8","path":"/finaglehelper","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/17730895?s=80&v=4"},"commit":{"message":"Twitter-oss: Prepare OSS libraries for release 24.5.0\n\nProblem\n\nWe want to release the next versions of our Twitter OSS libraries 24.5.0\n\nutil\nscrooge\nfinagle\ntwitter-server\nfinatra\nSolution\n\nPrepare libraries for their next releases.\n\nDifferential Revision: https://phabricator.twitter.biz/D1141504","shortMessageHtmlLink":"Twitter-oss: Prepare OSS libraries for release 24.5.0"}},{"before":"ea9908683c8ca0f61b63f7cffe4166029e4b9e9b","after":"768d5594dd95824c0f8d040e148a3d193c59880d","ref":"refs/heads/develop","pushedAt":"2024-05-06T18:11:47.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"finaglehelper","name":"BB-8","path":"/finaglehelper","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/17730895?s=80&v=4"},"commit":{"message":"Revert \"Twitter-oss: Prepare OSS libraries for release 24.2.0\"\n\nThis reverts commit 996858fd593b43d101d3c546d5a9968dc5408855.\n\nThere were issues with the release. Will be retrying it\n\nDifferential Revision: https://phabricator.twitter.biz/D1141484","shortMessageHtmlLink":"Revert \"Twitter-oss: Prepare OSS libraries for release 24.2.0\""}},{"before":"ba4db3f9c658782a2f3f24f5255b1b37744aafca","after":"09fc9f06e9cae051caa4d0a208d894bc20e5c3c0","ref":"refs/heads/gh-pages","pushedAt":"2024-05-03T18:32:44.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"finaglehelper","name":"BB-8","path":"/finaglehelper","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/17730895?s=80&v=4"},"commit":{"message":"site publish by finaglehelper","shortMessageHtmlLink":"site publish by finaglehelper"}},{"before":"5d3398519736fd67137b150bc44d5697ccc7285e","after":"ea9908683c8ca0f61b63f7cffe4166029e4b9e9b","ref":"refs/heads/release","pushedAt":"2024-05-02T20:26:18.000Z","pushType":"push","commitsCount":15,"pusher":{"login":"finaglehelper","name":"BB-8","path":"/finaglehelper","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/17730895?s=80&v=4"},"commit":{"message":"Twitter-oss: Prepare OSS libraries for release 24.2.0\n\nProblem\n\nWe want to release the next versions of our Twitter OSS libraries 24.2.0\n - util\n - scrooge\n - finagle\n - twitter-server\n - finatra\n\nSolution\n\nPrepare libraries for their next releases.\n\nDifferential Revision: https://phabricator.twitter.biz/D1140781","shortMessageHtmlLink":"Twitter-oss: Prepare OSS libraries for release 24.2.0"}},{"before":"88596885bcca8392ad50315e886cb7ff4e4e874c","after":"ea9908683c8ca0f61b63f7cffe4166029e4b9e9b","ref":"refs/heads/develop","pushedAt":"2024-05-02T16:11:43.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"finaglehelper","name":"BB-8","path":"/finaglehelper","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/17730895?s=80&v=4"},"commit":{"message":"Twitter-oss: Prepare OSS libraries for release 24.2.0\n\nProblem\n\nWe want to release the next versions of our Twitter OSS libraries 24.2.0\n - util\n - scrooge\n - finagle\n - twitter-server\n - finatra\n\nSolution\n\nPrepare libraries for their next releases.\n\nDifferential Revision: https://phabricator.twitter.biz/D1140781","shortMessageHtmlLink":"Twitter-oss: Prepare OSS libraries for release 24.2.0"}},{"before":"d1468ba3bbfcd1f6903e05ae9a994c983ba000d7","after":"88596885bcca8392ad50315e886cb7ff4e4e874c","ref":"refs/heads/develop","pushedAt":"2024-04-29T17:12:39.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"finaglehelper","name":"BB-8","path":"/finaglehelper","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/17730895?s=80&v=4"},"commit":{"message":"finagle/finagle-mysql: Move HandshakeSettingsTest into Bazel target and fix tests\n\nProblem\n\nThe HandshakeSettingsTest was outside of the mysql testing targets, so it didn't run\nas part of Bazel testing. This lead to a failing test being committed.\n\nSolution\n\nFix the test and move it into the `unit` target.\n\nDifferential Revision: https://phabricator.twitter.biz/D1140246","shortMessageHtmlLink":"finagle/finagle-mysql: Move HandshakeSettingsTest into Bazel target a…"}},{"before":"9002acaed920e763f272f564d22475b3608f8e8b","after":"d1468ba3bbfcd1f6903e05ae9a994c983ba000d7","ref":"refs/heads/develop","pushedAt":"2024-04-24T21:11:57.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"finaglehelper","name":"BB-8","path":"/finaglehelper","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/17730895?s=80&v=4"},"commit":{"message":"Finagle Toggles - Export toggle value metric\n\nAdding toggle value to observability data to enable the\nIntegration between [[ https://docbird.twitter.biz/precog/interfaces/instigator/FTInstigator.html |  Precog FT ]] and  [[ https://docs.google.com/document/d/1NwnQMOWeZp7Ys3wUePTdDrx3fQ3vTtMaHo22T9zBYz4/edit#heading=h.bz9cvnszgqss | Core Entity Service: Graceful Degradation\n ]]\n probing the toggle value using Observability metrics to avoid calling admin point for every shard\n\nDifferential Revision: https://phabricator.twitter.biz/D1138842","shortMessageHtmlLink":"Finagle Toggles - Export toggle value metric"}},{"before":"f9391d9ada5a778d5336e29bc00bf7e5af74cce1","after":"9002acaed920e763f272f564d22475b3608f8e8b","ref":"refs/heads/develop","pushedAt":"2024-04-23T14:11:38.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"finaglehelper","name":"BB-8","path":"/finaglehelper","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/17730895?s=80&v=4"},"commit":{"message":"finagle/finagle-mysql: Introduce param for configuring INTERACTIVE client flag\n\nProblem\n\nBy default, finagle-mysql creates an interactive client, which means the wait_timeout value\ncomes from the System_variables::net_interactive_timeout setting. However, on the database side,\nusers may configure the System_variables::net_wait_timeout and expect this to affect their client.\n\nSolution\n\nIntroduce an `interactive` param for configuring whether the client is interactive or not. It is interactive by default.\n\nDifferential Revision: https://phabricator.twitter.biz/D1138775","shortMessageHtmlLink":"finagle/finagle-mysql: Introduce param for configuring INTERACTIVE cl…"}},{"before":"a166c4784584201ae923adc859ba310ae55046f1","after":"f9391d9ada5a778d5336e29bc00bf7e5af74cce1","ref":"refs/heads/develop","pushedAt":"2024-04-18T20:12:09.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"finaglehelper","name":"BB-8","path":"/finaglehelper","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/17730895?s=80&v=4"},"commit":{"message":"finagle-memcached: Remove Compression Toggle\n\nRemove the toggle for enabling and disabling Lz4 compression as the compression has been tested on few services\n\nDifferential Revision: https://phabricator.twitter.biz/D1137993","shortMessageHtmlLink":"finagle-memcached: Remove Compression Toggle"}},{"before":"17b8d3212f1802d874788a6d9f78fbc95ca719ab","after":"a166c4784584201ae923adc859ba310ae55046f1","ref":"refs/heads/develop","pushedAt":"2024-03-28T16:18:22.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"finaglehelper","name":"BB-8","path":"/finaglehelper","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/17730895?s=80&v=4"},"commit":{"message":"finagle-memcached: Fix Compression Ratio Stats\n\nDifferential Revision: https://phabricator.twitter.biz/D1133694","shortMessageHtmlLink":"finagle-memcached: Fix Compression Ratio Stats"}},{"before":"454148fa209aea18f20cacb55a43bc4373cdd4b8","after":"17b8d3212f1802d874788a6d9f78fbc95ca719ab","ref":"refs/heads/develop","pushedAt":"2024-03-20T20:31:46.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"finaglehelper","name":"BB-8","path":"/finaglehelper","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/17730895?s=80&v=4"},"commit":{"message":"finagle-memcached: Implement compressing cache using lz4 compression\n\n**Problem** Make lz4 compression easily available via supported memcache\nclients. The desired effect is to drastically reduce the size of blobs stored in\nmemcache, with minimal CPU cost to the calling services.\n\n**Solution** The hypothesis is that we can drastically reduce the size of our\ntypical memcache payloads, at very low CPU cost, by using a throughput-oriented\ncompressor like lz4. This will drastically reduce the network utilization of\ncaches, improving performance in high-load situations like site failovers. This\nwill also improve the storage utilization of cache, which will reduce eviction\n(and perhaps increase cache hit rates of calling services). For larger blobs\nthat span >1 packet, this might also reduce cache tail latencies, by reducing\nthe number of packets needed to transmit an object and thereby reducing the\nchances of any one of them being delayed or needing a retransmit.\n\nBy using a few bits in the memcache protocol's flags field, this can be\nimplemented in a way that allows for a transparent upgrade. New blobs written to\nthe store will be compressed - existing blobs will be unmodified. The bits in\nthe flags field will be used to signal whether the blob is compressed.\nTransparent upgrades will make adoption of this significantly easier, as the\nexisting cached data in the cluster can be used while the transition occurs.\n\n**Result** ~30% compression for the higher sized items and 15-20% from p40\nonwards\n\nDifferential Revision: https://phabricator.twitter.biz/D1130236","shortMessageHtmlLink":"finagle-memcached: Implement compressing cache using lz4 compression"}},{"before":"48d04c155fc31b87e4d0f8d520234a9b7b5b5e45","after":"454148fa209aea18f20cacb55a43bc4373cdd4b8","ref":"refs/heads/develop","pushedAt":"2024-02-09T17:18:51.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"finaglehelper","name":"BB-8","path":"/finaglehelper","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/17730895?s=80&v=4"},"commit":{"message":"[source] Update PROJECT owner references to reflect deactivated ldap\n\n[source] Update PROJECT owner references to reflect deactivated ldap\n\nDifferential Revision: https://phabricator.twitter.biz/D1125334","shortMessageHtmlLink":"[source] Update PROJECT owner references to reflect deactivated ldap"}},{"before":"51b701eefeb2b34a5a85e470d4bf8f885ebfd1e1","after":"48d04c155fc31b87e4d0f8d520234a9b7b5b5e45","ref":"refs/heads/develop","pushedAt":"2024-01-17T12:17:49.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"finaglehelper","name":"BB-8","path":"/finaglehelper","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/17730895?s=80&v=4"},"commit":{"message":"[finagle-core] Eliminate unnecessary calls in the filter chain\n\nProblem\nFor extra safety we wrap the next service in the chain with Service.rescue, even though in the majority of cases it's an adapter between Service and Filter interfaces.\n\nSolution\nEliminate this extra call.\n\nBefore\n```\nBenchmark                      (numAndThens)  Mode  Cnt    Score   Error  Units\nFilterBenchmark.andThenFilter             20  avgt   10   55.079 ± 0.294  ns/op\nFilterBenchmark.andThenFilter             50  avgt   10  163.251 ± 0.903  ns/op\n```\n\nAfter\n```\nBenchmark                      (numAndThens)  Mode  Cnt   Score   Error  Units\nFilterBenchmark.andThenFilter             20  avgt   10  29.767 ± 0.206  ns/op\nFilterBenchmark.andThenFilter             50  avgt   10  86.184 ± 0.588  ns/op\n```\n\nDifferential Revision: https://phabricator.twitter.biz/D1120263","shortMessageHtmlLink":"[finagle-core] Eliminate unnecessary calls in the filter chain"}},{"before":"d905fa7995f18ba8573d7e8f9983ba939b1c57d3","after":"51b701eefeb2b34a5a85e470d4bf8f885ebfd1e1","ref":"refs/heads/develop","pushedAt":"2024-01-16T23:18:08.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"finaglehelper","name":"BB-8","path":"/finaglehelper","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/17730895?s=80&v=4"},"commit":{"message":"[finagle-core] Fix for DeadlineFilter takes rejectWithdrawal regardless of passed Deadline\n\nProblem\nDeadlineFilter takes rejectWithdrawal regardless of passed Deadline\nhttps://github.com/twitter/finagle/issues/936\n\nSolution\nWithdraw tokens only if the deadline has passed\n\nCloses twitter/finagle#936\n\nDifferential Revision: https://phabricator.twitter.biz/D1120240","shortMessageHtmlLink":"[finagle-core] Fix for DeadlineFilter takes rejectWithdrawal regardle…"}},{"before":"8baf8028a954937bf56577cae08a39283bd6951a","after":"d905fa7995f18ba8573d7e8f9983ba939b1c57d3","ref":"refs/heads/develop","pushedAt":"2023-12-22T23:17:47.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"finaglehelper","name":"BB-8","path":"/finaglehelper","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/17730895?s=80&v=4"},"commit":{"message":"[finagle] do not fail full toggle map parsing when duplicate toggles exist in a file\n\nProblem:\n\nCurrently the finagle toggle map parser fails parsing of all elements in a\ntoggle file when a single duplicate entry is added. While this fail fast\nbehavior is good in some cases (especially when toggles are loaded locally),\nit's not a great behavior in production systems where toggles are committed and\nloaded separately. In such scenarios, if the file is already committed and old\nversion is unavailable to the system it is preferable to have the toggle map\nload as much as it can to prevent breaking other toggles in the file.\n\nSolution:\n\nAdd an opt in setting to keep the first entry when a duplicate is encountered\ninstead of failing to parse the whole thing\n\nDifferential Revision: https://phabricator.twitter.biz/D1117265","shortMessageHtmlLink":"[finagle] do not fail full toggle map parsing when duplicate toggles …"}},{"before":"1609ebb6a49cf7454da7eb7ed76ea27b4f5173eb","after":"8baf8028a954937bf56577cae08a39283bd6951a","ref":"refs/heads/develop","pushedAt":"2023-12-15T01:17:24.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"finaglehelper","name":"BB-8","path":"/finaglehelper","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/17730895?s=80&v=4"},"commit":{"message":"finagle-core: Limit the maximum number of jobs in the thread pool backing the offload filter\n\nProblem\nThe existence of an unbound queue anywhere can cause the application to run out of memory and terminate unexpectedly.\n\nSolution\nAllow the service owner to limit the length of the queue with some reasonable number.\n\nDifferential Revision: https://phabricator.twitter.biz/D1116102","shortMessageHtmlLink":"finagle-core: Limit the maximum number of jobs in the thread pool bac…"}},{"before":"92c7d4dc1d98851d089494a351c2016d2043991c","after":"1609ebb6a49cf7454da7eb7ed76ea27b4f5173eb","ref":"refs/heads/develop","pushedAt":"2023-11-05T01:11:35.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"finaglehelper","name":"BB-8","path":"/finaglehelper","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/17730895?s=80&v=4"},"commit":{"message":"finagle/finagle-thriftmux: Fix flakey thriftmux.MethodBuilder test\n\nProblem\n\nWhen testing deadline application in the timeout filter, we expect a GlobalRequestTimeout\nto be thrown from the global timeout filter due to the short deadline. However, an\nIndividualRequestTimeoutException can also be thrown -- the filters set very similar\ntimeouts due to the deadline being shorter than each of their respective timeouts, and\nhence the interrupts race.\n\nSolution\n\nException a generic RequestTimeoutException instead.\n\nJIRA Issues: CSL-12415\n\nDifferential Revision: https://phabricator.twitter.biz/D1108542","shortMessageHtmlLink":"finagle/finagle-thriftmux: Fix flakey thriftmux.MethodBuilder test"}},{"before":"424d91da9ce4786a47a788c780fbb24707f065d8","after":"92c7d4dc1d98851d089494a351c2016d2043991c","ref":"refs/heads/develop","pushedAt":"2023-11-04T04:18:00.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"finaglehelper","name":"BB-8","path":"/finaglehelper","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/17730895?s=80&v=4"},"commit":{"message":"The test target \"finagle/finagle-thriftmux/src/test/scala:scala\" is failing too often in master in CI.\n\nSummary:\nProblem:\n\nThe test target \"finagle/finagle-thriftmux/src/test/scala:scala\" is failing too often in master in CI.\n\nLogs available here:\n\nKnown to fail ticket: [CSL-12415](https://jira.twitter.biz/browse/CSL-12415)\n\nSolution:\n\nIt has been marked \"known-to-fail\" in the BUILD file\n\nResult:\n\nThis will cause it to be skipped in future builds, and its failures ignored in submit queue. This implies that code changes that further break this test will not be prevented from being submitted to the master branch, until the problem is fixed and the test is no longer marked known-to-fail.\n\nReviewers: O865 source:/finagle/finagle-thriftmux/!\n\nDifferential Revision: https://phabricator.twitter.biz/D1108489\n\nTBR=true","shortMessageHtmlLink":"The test target \"finagle/finagle-thriftmux/src/test/scala:scala\" is f…"}},{"before":"ce0b60cecae0bc629dbe7720a1057ea2e99b424a","after":"5d3398519736fd67137b150bc44d5697ccc7285e","ref":"refs/heads/release","pushedAt":"2023-11-02T09:40:42.000Z","pushType":"push","commitsCount":26,"pusher":{"login":"finaglehelper","name":"BB-8","path":"/finaglehelper","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/17730895?s=80&v=4"},"commit":{"message":"Cut version 23.11\n\nProblem/Solution:\n\nCut version 23.11 of:\n - util\n - scrooge\n - finagle\n - twitter-server\n - finatra\n\nDifferential Revision: https://phabricator.twitter.biz/D1107956","shortMessageHtmlLink":"Cut version 23.11"}},{"before":"5d3398519736fd67137b150bc44d5697ccc7285e","after":"424d91da9ce4786a47a788c780fbb24707f065d8","ref":"refs/heads/develop","pushedAt":"2023-11-02T09:31:08.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"finaglehelper","name":"BB-8","path":"/finaglehelper","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/17730895?s=80&v=4"},"commit":{"message":"update to snapshot 24.2.0-snapshot\n\nProblem/Solution:\n\nCut snapshot 24.2.0 of:\n - util\n - scrooge\n - finagle\n - twitter-server\n - finatra\n\nDifferential Revision: https://phabricator.twitter.biz/D1108018","shortMessageHtmlLink":"update to snapshot 24.2.0-snapshot"}},{"before":"3c27308e590bd32b59f0e44b5bc7c6a75d0130ad","after":"5d3398519736fd67137b150bc44d5697ccc7285e","ref":"refs/heads/develop","pushedAt":"2023-11-02T00:18:01.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"finaglehelper","name":"BB-8","path":"/finaglehelper","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/17730895?s=80&v=4"},"commit":{"message":"Cut version 23.11\n\nProblem/Solution:\n\nCut version 23.11 of:\n - util\n - scrooge\n - finagle\n - twitter-server\n - finatra\n\nDifferential Revision: https://phabricator.twitter.biz/D1107956","shortMessageHtmlLink":"Cut version 23.11"}},{"before":"aa73d4136337181c6c0b2470f91ba8c6901bab74","after":"3c27308e590bd32b59f0e44b5bc7c6a75d0130ad","ref":"refs/heads/develop","pushedAt":"2023-11-01T19:17:39.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"finaglehelper","name":"BB-8","path":"/finaglehelper","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/17730895?s=80&v=4"},"commit":{"message":"finagle-core: Rename c.t.f.context.Retries to c.t.f.context.Requeues\n\nProblem\n\n`c.t.f.context.Retries` is not an accurate name because it actually stores the\nnumber of *requeues* a request has had.\n\nSolution\n\nRename it to `c.t.f.context.Requeues`.\n\nDifferential Revision: https://phabricator.twitter.biz/D1104878","shortMessageHtmlLink":"finagle-core: Rename c.t.f.context.Retries to c.t.f.context.Requeues"}},{"before":"610a21cac42b086170600097c94f0963511382ae","after":"aa73d4136337181c6c0b2470f91ba8c6901bab74","ref":"refs/heads/develop","pushedAt":"2023-11-01T17:18:26.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"finaglehelper","name":"BB-8","path":"/finaglehelper","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/17730895?s=80&v=4"},"commit":{"message":"[finagle-core]: Pass through configured deadline params rather than use default\n\nProblem\n\nWe can set the `TimeoutFilter.PropagateDeadlines` and\n`TimeoutFilter.PreferDeadlineOverTimeout` to configure behavior on the Client.\nWhen the MethodBuilder interface is used, the `perRequestModule` does only look\nat the `Default` values of these configurations, preventing custom configuration.\n\nSolution\n\nPass the `TimeoutFilter.PropagateDeadlines` and\n`TimeoutFilter.PreferDeadlineOverTimeout` as Params to the `perRequestModule` to\ninstantiate the `TimeoutFilter` with correct configuration.\n\nResult\n\nThe MethodBuilder will pick up configured `TimeoutFilter.PropagateDeadlines`\nand `TimeoutFilter.PreferDeadlineOverTimeout` parameters.\n\nCloses twitter/finagle#937\n\ncompile\n\nDifferential Revision: https://phabricator.twitter.biz/D1107765","shortMessageHtmlLink":"[finagle-core]: Pass through configured deadline params rather than u…"}},{"before":"00380519e870565886f255108e2d4ba7885045a0","after":"610a21cac42b086170600097c94f0963511382ae","ref":"refs/heads/develop","pushedAt":"2023-11-01T15:17:37.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"finaglehelper","name":"BB-8","path":"/finaglehelper","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/17730895?s=80&v=4"},"commit":{"message":"[finagle-http2]: Add a per session request limit option to http2\n\nSee https://github.com/twitter/finagle/pull/954 for original description,\nand included imagery.\n\nProblem:\nWhen running finagle in a setup using HTTP/2 via application load\nbalancers (ALB), the session is very likely subject to a limit on the number of\nrequests. E.g. when running via NGINX, the request limit is 1K requests per\nconnection by default. On AWS, ALB have a 10k request limit. This means that in\nsetups that use finagle and ALBs for their L7 features, the session is subject\nto races happening on connection close regularly.\nNetty fires inactive channel for any request that is in flight for the closed\nsession, leading Finagle to propagate a ChannelClosedException. There is no\npossible remediation for this race in Netty since Finagle manages\nsessions/connections.\n\nThis condition can be easily reproduced by running a Finagle server & client\nwith an ALB like NGINX in between, sending concurrent requests up until the\nlimit.\n\nSolution:\nAllow configuration of a MaxRequestsPerSession option that aligns a session with\nunderlying request limits. The number ofMaxConcurrentStreams is deducted to\naccount for any requests in flight. When this number of requests is reached,\nmark the session as closed so it is shut down and a new session is created.\n\nThis option is off by default and therefore opt-in.\n\nResult\nWhen the configured number of requests is reached, the session is terminated and\na new session is opened\n\nCloses twitter/finagle#954\n\nDifferential Revision: https://phabricator.twitter.biz/D1107613","shortMessageHtmlLink":"[finagle-http2]: Add a per session request limit option to http2"}},{"before":"97abd88c4cda5d94d358ff222959cbf8e1c27e4a","after":"00380519e870565886f255108e2d4ba7885045a0","ref":"refs/heads/develop","pushedAt":"2023-11-01T14:18:42.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"finaglehelper","name":"BB-8","path":"/finaglehelper","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/17730895?s=80&v=4"},"commit":{"message":"[Twitter-oss] bump release version\n\n[Twitter-oss] bump release version\n\nDifferential Revision: https://phabricator.twitter.biz/D1107767","shortMessageHtmlLink":"[Twitter-oss] bump release version"}},{"before":"7d6a5569aa82150b88e5fa08b561b451d303efaf","after":"97abd88c4cda5d94d358ff222959cbf8e1c27e4a","ref":"refs/heads/develop","pushedAt":"2023-11-01T01:18:05.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"finaglehelper","name":"BB-8","path":"/finaglehelper","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/17730895?s=80&v=4"},"commit":{"message":"[finagle-mysql] Fix Finagle MySQL transactionWithIsolation doc typo\n\nFix Finagle MySQL transactionWithIsolation doc typo\n\nResult\n\nCloses twitter/finagle#942\n\nDifferential Revision: https://phabricator.twitter.biz/D1107691","shortMessageHtmlLink":"[finagle-mysql] Fix Finagle MySQL transactionWithIsolation doc typo"}},{"before":"83e31f81361430a427fe9d4b636419b52d42542c","after":"7d6a5569aa82150b88e5fa08b561b451d303efaf","ref":"refs/heads/develop","pushedAt":"2023-10-31T20:18:03.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"finaglehelper","name":"BB-8","path":"/finaglehelper","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/17730895?s=80&v=4"},"commit":{"message":"[finagle]: Portable shebang\n\nProblem:\n\n/bin/bash is not available on non-FHS distros, such as NixOS\n\nSolution:\n\nReplace /bin/bash with /usr/bin/env bash\n\nResult:\n\nCloses twitter/finagle#959\n\nDifferential Revision: https://phabricator.twitter.biz/D1107565","shortMessageHtmlLink":"[finagle]: Portable shebang"}},{"before":"c07b9d07c509019e086ff0d9a81ab0fccd154bf6","after":"83e31f81361430a427fe9d4b636419b52d42542c","ref":"refs/heads/develop","pushedAt":"2023-10-16T15:18:08.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"finaglehelper","name":"BB-8","path":"/finaglehelper","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/17730895?s=80&v=4"},"commit":{"message":"finagle-core: add recvAddress to IOExceptionStrings\n\n[Problem]\nfinagle/finagle-http/src/test/scala:scala becomes flaky after Netty upgrade to 4.1.100.Final.\nIt was become some tests fail with\n```\nCaused by: com.twitter.finagle.UnknownChannelException: recvAddress(..) failed:\nConnection reset by peer at remote address: 0.0.0.0/127.0.0.1:34938 from service: client.\nRemote Info: Upstream Address: Not Available, Upstream id: Not Available, Downstream Address: /0.0.0.0:34938,\nDownstream label: client, Trace Id: b9f67d678f5fac8c.b9f67d678f5fac8c<:b9f67d678f5fac8c\n```\nand they are expected to com.twitter.finagle.ChannelClosedException\n\n[Solution]\nAdd `recvAddress(..) failed: Connection reset by peer` to the\nlist of known exception strings\n\nJIRA Issues: CSL-12408\n\nDifferential Revision: https://phabricator.twitter.biz/D1104650","shortMessageHtmlLink":"finagle-core: add recvAddress to IOExceptionStrings"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEQ_ijAQA","startCursor":null,"endCursor":null}},"title":"Activity · twitter/finagle"}