Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type annotations to __eq__() et al #9919

Closed
twisted-trac opened this issue Jul 20, 2020 · 3 comments
Closed

Add type annotations to __eq__() et al #9919

twisted-trac opened this issue Jul 20, 2020 · 3 comments

Comments

@twisted-trac
Copy link

mthuurne's avatar @mthuurne reported
Trac ID trac#9919
Type enhancement
Created 2020-07-20 23:22:08Z

These methods have fixed signatures, so it's easy to add type annotations for them with a simple text substitution over the entire source tree.

However, since mypy will check the body of annotated methods, this means mypy coverage grows and that we'll have to fix some method bodies as a result.

Searchable metadata
trac-id__9919 9919
type__enhancement enhancement
reporter__mthuurne mthuurne
priority__normal normal
milestone__publish_types publish types
branch__ 
branch_author__ 
status__closed closed
resolution__fixed fixed
component__core core
keywords__review review
time__1595287328127895 1595287328127895
changetime__1595356040061596 1595356040061596
version__None None
owner__mthuurne mthuurne

@twisted-trac
Copy link
Author

mthuurne's avatar @mthuurne commented

PR is ready for review: #1361

@twisted-trac
Copy link
Author

rodrigc's avatar @rodrigc set owner to @mthuurne

Approved: #1361 (review)

@twisted-trac
Copy link
Author

mthuurne's avatar @mthuurne set status to closed

In changeset d47dafe

#!CommitTicketReference repository="" revision="d47dafe0717b3877d5d0017ab0feb0721cb78613"
Merge pull request #1361 from twisted/9919-mthuurne-annotate_comparators

Add type annotations to __eq__() et al

Author: mthuurne
Reviewer: rodrigc
Fixes: ticket:9919

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant