"loseConnection" in base class "ConnectionMixin" is incompatible with definition in base class "FileDescriptor"

[twisted-trac]

	@rodrigc reported
Trac ID	trac#9849
Type	defect
Created	2020-06-16 17:34:48Z

In twisted.internet.abstract.FileDescriptor.loseConnection, the loseConnection method
is defined like:

    def loseConnection(self, _connDone=failure.Failure(main.CONNECTION_DONE)):

while in twisted.internet._newtls.ConnectionMixin , we have:

  def loseConnection(self):

If I run tox -e mypy in trunk, mypy complains with this:

src/twisted/internet/tcp.py:204:1: error: Definition of "loseConnection" in base class "ConnectionMixin" is incompatible with definition in base class "FileDescriptor"  [misc]

src/twisted/internet/tcp.py:527:1: error: Definition of "loseConnection" in base class "ConnectionMixin" is incompatible with definition in base class "FileDescriptor"  [misc]
src/twisted/internet/tcp.py:780:1: error: Definition of "loseConnection" in base class "ConnectionMixin" is incompatible with definition in base class "FileDescriptor"  [misc]
src/twisted/internet/tcp.py:789:1: error: Definition of "loseConnection" in base class "ConnectionMixin" is incompatible with definition in base class "FileDescriptor"  [misc]

src/twisted/internet/unix.py:243:1: error: Definition of "loseConnection" in base class "ConnectionMixin" is incompatible with definition in base class "FileDescriptor"  [misc]
src/twisted/internet/unix.py:431:1: error: Definition of "loseConnection" in base class "ConnectionMixin" is incompatible with definition in base class "FileDescriptor"  [misc]

It would be good to fix this.

Searchable metadata

trac-id__9849 9849
type__defect defect
reporter__rodrigc rodrigc
priority__normal normal
milestone__publish_types publish types
branch__ 
branch_author__ 
status__closed closed
resolution__fixed fixed
component__core core
keywords__None None
time__1592328888078225 1592328888078225
changetime__1594360403322407 1594360403322407
version__None None
owner__Craig_Rodrigues__rodrigc_____ Craig Rodrigues <rodrigc@...>

[twisted-trac]

	@rodrigc commented

The signature for loseConnection() was modified here:
081d393

I think changing the signature in this way was wrong.

[twisted-trac]

	@rodrigc commented

#1292

[twisted-trac]

	@rodrigc commented

Approved here: #1292 (review)

[twisted-trac]

	@rodrigc set owner to @rodrigc @rodrigc set status to closed

In changeset a0754eb

#!CommitTicketReference repository="" revision="a0754ebc7ec3b527c5d414d84ba575b2284aa90b"
Merge pull request #1292 from twisted/9849-rodrigc-loseconnection-mypy

Remove _connDone parameter from FileDescriptor.loseConnection()

Author: rodrigc
Reviewer: adiroiban
Fixes: ticket:9849