trial does not honor unittest @skipIf decorator on classes

[twisted-trac]

	@rodrigc reported
Trac ID	trac#9829
Type	enhancement
Created	2020-05-13 21:26:45Z

The @unittest.skipIf decorator ( https://docs.python.org/3/library/unittest.html#skipping-tests-and-expected-failures ) instructs a test runner such as pytest or unittest to skip a specific test function.
This partially works with trial.

This works with trial, i.e. the test_skipThis() function gets marked as SKIPPED:

class MyTests(TestCase):

       @skipIf(True, "skip reason")
       def test_skipThis(self):

This does not work with trial, i.e. all the tests in the SkipAllTests class are executed instead of skipped.

@skipIf(True, "skip reason")
class SkipAllTests(TestCase):

       def test_skipThisFirst(self):
           print("Should never get here first")

        def test_skipThisSecond(self):
            print("Should never get here second")

It would be good to enhance trial to honor the @skipIf decorator on classes.

In the @skipIf implementation, two attributes are set unittest_skip and unittest_skip_why:

See: skipIf implementation

In the unittest runner, these attributes are checked:

unittest implementation checks attributes

The pytest runner also checks these attributes:

pytest implementation checks attribute

So trial should be enhanced to behave like unittest and pytest.

Searchable metadata

trac-id__9829 9829
type__enhancement enhancement
reporter__rodrigc rodrigc
priority__normal normal
milestone__None None
branch__ 
branch_author__ 
status__closed closed
resolution__fixed fixed
component__trial trial
keywords__None None
time__1589405205483644 1589405205483644
changetime__1590940454705386 1590940454705386
version__None None
owner__Craig_Rodrigues__rodrigc_____ Craig Rodrigues <rodrigc@...>

[twisted-trac]

	@rodrigc commented

#1272

[twisted-trac]

	@rodrigc commented

Approved here: #1272 (review)

[twisted-trac]

	@rodrigc set owner to @rodrigc @rodrigc set status to closed

In changeset 52e7518

#!CommitTicketReference repository="" revision="52e7518232b5031ae38e1e477786a0afa761df9b"
Merge pull request #1272 from twisted/9829-rodrigc-trial

Allow @unittest.skipIf decorator to specify that a test class should be skipped

Author: rodrigc
Reviewer: adiroiban
Fixes: ticket:9829