'Failed to reap %d:' logging fails for None PIDs

[twisted-trac]

	@altendky reported
Trac ID	trac#9775
Type	defect
Created	2020-03-15 01:26:10Z

A None PID shouldn't be being reaped but when it happens you just get an extra layer of errors to deal with.

twisted/src/twisted/internet/process.py

Line 80 in 20c787a

log.msg('Failed to reap %d:' % pid)

twisted/src/twisted/internet/process.py

Line 307 in 20c787a

log.msg('Failed to reap %d:' % self.pid)

This came up while working on pytest-dev/pytest-twisted#93.

The small solution is to switch to a string format rather then %d (%s or '{}'.format() etc).

It was suggested that the module should also be converted to use twisted.logger but I'm not going to take that on at this point and it isn't required to address the specific issue. Sorry... :[

Searchable metadata

trac-id__9775 9775
type__defect defect
reporter__altendky altendky
priority__normal normal
milestone__None None
branch__ 
branch_author__ 
status__closed closed
resolution__fixed fixed
component__core core
keywords__None None
time__1584235570996590 1584235570996590
changetime__1586726867698940 1586726867698940
version__None None
owner__altendky altendky
cc__altendky

[twisted-trac]

	@altendky commented

PR: #1230

[twisted-trac]

	@altendky set owner to @altendky @altendky set status to assigned

[twisted-trac]

	@altendky removed owner @altendky set status to new

[twisted-trac]

	@rodrigc set owner to @altendky

Approved: #1230 (review)

[twisted-trac]

	@rodrigc set status to closed

In changeset ed47278

#!CommitTicketReference repository="" revision="ed4727842aefd62803f26489b1cd1eadbbfc5c6e"
Merge pull request #1230 from altendky/9775-altendky-log_failed_to_reap_for_none_pid

[9775] Avoid log failure when reaping of None PID is requested

Author: altendky
Reviewers: rodrigc
Fixes: ticket:9775