Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"tox -e lint" is confusing if branch isn't up to date with trunk #9737

Closed
twisted-trac opened this issue Nov 24, 2019 · 4 comments
Closed

"tox -e lint" is confusing if branch isn't up to date with trunk #9737

twisted-trac opened this issue Nov 24, 2019 · 4 comments

Comments

@twisted-trac
Copy link

cjwatson's avatar @cjwatson reported
Trac ID trac#9737
Type enhancement
Created 2019-11-24 13:15:03Z

If trunk has commits that haven't been merged into the branch you're working on, then "tox -e lint" is confusing because it operates on the output of "git diff trunk", which diffs against the current trunk rather than against the common ancestor. Using "git diff $(git merge-base trunk HEAD)" instead would be 100% less confusing.

Searchable metadata
trac-id__9737 9737
type__enhancement enhancement
reporter__cjwatson cjwatson
priority__normal normal
milestone__None None
branch__ 
branch_author__ 
status__closed closed
resolution__fixed fixed
component__release_management release management
keywords__None None
time__1574601303270366 1574601303270366
changetime__1576475083875321 1576475083875321
version__None None
owner__Tom_Most__twm_____ Tom Most <twm@...>

@twisted-trac
Copy link
Author

cjwatson's avatar @cjwatson commented

#1203

@twisted-trac
Copy link
Author

twm's avatar @twm set owner to @twm
@twm set status to assigned

@twisted-trac
Copy link
Author

twm's avatar @twm removed owner
@twm set status to new

Looks great, thank you! I love to see DX improvements like this.

#1203 (review)

@twisted-trac
Copy link
Author

twm's avatar @twm set owner to @twm
@twm set status to closed

In changeset 0a0b59b

#!CommitTicketReference repository="" revision="0a0b59bf63473d521459025ba7ae060f98760000"
Merge pull request #1203 from cjwatson/9737-lint-dotdotdot

Author: cjwatson
Reviewer: twm
Fixes: ticket:9737

Run pycodestyle-twisted against merge-base with trunk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants