Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Contextvars in coroutines (inlineCallbacks/ensureDeferred) #9719

Closed
twisted-trac opened this issue Oct 20, 2019 · 5 comments
Closed

Comments

@twisted-trac
Copy link

hawkowl's avatar @hawkowl reported
Trac ID trac#9719
Type enhancement
Created 2019-10-20 12:18:25Z

Contextvars is a method of supporting thread-local like information but in Deferred and Future like concurrency systems. https://docs.python.org/3.7/library/contextvars.html

This ticket involves adding support to the coroutine systems.

Searchable metadata
trac-id__9719 9719
type__enhancement enhancement
reporter__hawkowl hawkowl
priority__normal normal
milestone__None None
branch__ 
branch_author__ 
status__closed closed
resolution__fixed fixed
component__core core
keywords__None None
time__1571573905585172 1571573905585172
changetime__1588323332267627 1588323332267627
version__None None
owner__hawkowl hawkowl

@twisted-trac
Copy link
Author

glyph's avatar @glyph commented

See WIP here #1192

@twisted-trac
Copy link
Author

hawkowl's avatar @hawkowl commented

PR up for initial review: #1192

@twisted-trac
Copy link
Author

glyph's avatar @glyph set owner to @hawkowl

Review up at #1192 (review) - big changes requested, unfortunately.

@twisted-trac
Copy link
Author

glyph's avatar @glyph commented

Okay not that review, this review: #1192 (review)

@twisted-trac
Copy link
Author

glyph's avatar @glyph set status to closed

In changeset db811a3

#!CommitTicketReference repository="" revision="db811a3af536cfef6d083b247e506de8e91a22f7"
Merge pull request #1192 from twisted/9719-contextvars

Author: hawkowl

Reviewer: glyph

Fixes: ticket:9719

Support contextvars in ensureDeferred and inlineCallbacks coroutines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants