Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

date, time, and timedelta objects are not jellied properly in python3 #9716

Closed
twisted-trac opened this issue Oct 17, 2019 · 6 comments
Closed

Comments

@twisted-trac
Copy link

mathieui's avatar @mathieui reported
Trac ID trac#9716
Type defect
Created 2019-10-17 12:50:14Z

When using Banana, the objects are converted to unicode strings which cannot be sent, instead of byte strings like other objecs.

This results in a lengthy traceback inside the twisted sending stack which ends with "twisted.spread.banana.BananaError: Banana cannot send builtins.str objects: '9 38102 277591'"

Searchable metadata
trac-id__9716 9716
type__defect defect
reporter__mathieui mathieui
priority__normal normal
milestone__Python_3_x Python-3.x
branch__ 
branch_author__ 
status__closed closed
resolution__fixed fixed
component__core core
keywords__None None
time__1571316614355317 1571316614355317
changetime__1594495735895646 1594495735895646
version__None None
owner__glyph glyph

@twisted-trac
Copy link
Author

mathieui's avatar @mathieui commented

Pull request here: #1191

@twisted-trac
Copy link
Author

exarkun's avatar @exarkun commented

Hi mathieui. If you're interested in twisted.spread you may want to have a look at https://twistedmatrix.com/pipermail/twisted-python/2019-April/032291.html

@twisted-trac
Copy link
Author

exarkun's avatar @exarkun set owner to @mathieui

Thanks. Left a review on GitHub.

@twisted-trac
Copy link
Author

glyph's avatar @glyph removed owner

In review again over here: #1350

That PR includes commits from the previous PR, so it should auto-close when done.

As far as I could tell, the previous build failure (whatever it was) was something intermittent, no longer relevant

@twisted-trac
Copy link
Author

rodrigc's avatar @rodrigc set owner to @glyph

Approved here: #1350 (review)

@twisted-trac
Copy link
Author

glyph's avatar @glyph set status to closed

In changeset 7adb468

#!CommitTicketReference repository="" revision="7adb46869d9b215e2a01fe7194a715a60579ddbc"
Merge pull request #1350 from twisted/9716-jelly-timedelta-redux

Author: mathieui, glyph

Reviewer: rodrigc

Fixes: ticket:9716

Fixed serialization of timedelta, date, and time objects in twisted.spread.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants