Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use standard mechanisms to require Python versions #9701

Closed
twisted-trac opened this issue Aug 20, 2019 · 6 comments
Closed

Use standard mechanisms to require Python versions #9701

twisted-trac opened this issue Aug 20, 2019 · 6 comments

Comments

@twisted-trac
Copy link

altendky's avatar @altendky reported
Trac ID trac#9701
Type enhancement
Created 2019-08-20 18:52:57Z
Branch https://github.com/altendky/twisted/tree/9701-altendky-add_python_requires

https://twistedmatrix.com/pipermail/twisted-python/2019-August/032441.html

It was noted in the above email that pip ought be able to tell the compatible versions from PyPI metadata rather than waiting for our custom code to raise an exception.

I believe this would be achieved by filling out the python_requires metadata for setuptools.

python_requires='>=2.7,!=3.0.*,!=3.1.*,!=3.2.*,!=3.3.*!=3.4.*'

This is ugly but last I looked it's what I came up with.

It may still be desired to keep the existing check in case part of the Twisted code that calculates the setuptools.setup() arguments is itself not compatible. This would still be relevant when being installed from an sdist or otherwise from source.

PR: #1183

Searchable metadata
trac-id__9701 9701
type__enhancement enhancement
reporter__altendky altendky
priority__normal normal
milestone__None None
branch__altendky_9701_altendky_add_python_requires altendky:9701-altendky-add_python_requires
branch_author__ 
status__closed closed
resolution__fixed fixed
component__core core
keywords__review review
time__1566327177160055 1566327177160055
changetime__1576098484770153 1576098484770153
version__None None
owner__None None
cc__altendky
@twisted-trac
Copy link
Author

altendky's avatar @altendky commented

Commented in PR: #1183 (comment)

@twisted-trac
Copy link
Author

altendky's avatar @altendky set owner to @altendky

@twisted-trac
Copy link
Author

altendky's avatar @altendky set owner to @wsanchez

@twisted-trac
Copy link
Author

wsanchez's avatar @wsanchez commented

Out of curiosity, why was this assigned to me?

@twisted-trac
Copy link
Author

wsanchez's avatar @wsanchez removed owner

@twisted-trac
Copy link
Author

wsanchez's avatar @wsanchez set status to closed

merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant