Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raiser.c is busted again on cpython 3.8.0b2 #9674

Closed
twisted-trac opened this issue Jul 20, 2019 · 3 comments
Closed

raiser.c is busted again on cpython 3.8.0b2 #9674

twisted-trac opened this issue Jul 20, 2019 · 3 comments

Comments

@twisted-trac
Copy link

hawkowl's avatar @hawkowl reported
Trac ID trac#9674
Type defect
Created 2019-07-20 14:42:28Z

Fail to compile, needs regenerating.

gcc -pthread -Wno-unused-result -Wsign-compare -DNDEBUG -g -fwrapv -O3 -Wall -march=x86-64 -march=x86-64 -march=x86-64 -fPIC -I/home/hawkowl/opt/py3.8/include/python3.8 -c src/twisted/test/raiser.c -o build/temp.linux-x86_64-3.8/src/twisted/test/raiser.o
  src/twisted/test/raiser.c: In function ‘__Pyx_InitCachedConstants’:
  /home/hawkowl/opt/py3.8/include/python3.8/code.h:72:25: warning: passing argument 6 of ‘PyCode_New’ makes pointer from integer without a cast [-Wint-conversion]
     72 | #define CO_OPTIMIZED    0x0001
        |                         ^
        |                         |
        |                         int
  src/twisted/test/raiser.c:333:37: note: in definition of macro ‘__Pyx_PyCode_New’
    333 |           PyCode_New(a, p, k, l, s, f, code, c, n, v, fv, cell, fn, name, fline, lnos)
        |                                     ^
  src/twisted/test/raiser.c:1306:63: note: in expansion of macro ‘CO_OPTIMIZED’
   1306 |   __pyx_codeobj_ = (PyObject*)__Pyx_PyCode_New(0, 0, 0, 0, 0, CO_OPTIMIZED|CO_NEWLOCALS, __pyx_empty_bytes, __pyx_empty_tuple, __pyx_empty_tuple, __pyx_empty_tuple, __pyx_empty_tuple, __pyx_empty_tuple, __pyx_kp_s_raiser_pyx, __pyx_n_s_raiseException, 17, __pyx_empty_bytes); if (unlikely(!__pyx_codeobj_)) __PYX_ERR(0, 17, __pyx_L1_error)
        |                                                               ^~~~~~~~~~~~
  In file included from /home/hawkowl/opt/py3.8/include/python3.8/compile.h:5,
                   from /home/hawkowl/opt/py3.8/include/python3.8/Python.h:138,
                   from src/twisted/test/raiser.c:4:
  /home/hawkowl/opt/py3.8/include/python3.8/code.h:122:28: note: expected ‘PyObject *’ {aka ‘struct _object *’} but argument is of type ‘int’
    122 | PyAPI_FUNC(PyCodeObject *) PyCode_New(
        |                            ^~~~~~~~~~
  src/twisted/test/raiser.c:1306:227: warning: passing argument 14 of ‘PyCode_New’ makes integer from pointer without a cast [-Wint-conversion]
   1306 |   __pyx_codeobj_ = (PyObject*)__Pyx_PyCode_New(0, 0, 0, 0, 0, CO_OPTIMIZED|CO_NEWLOCALS, __pyx_empty_bytes, __pyx_empty_tuple, __pyx_empty_tuple, __pyx_empty_tuple, __pyx_empty_tuple, __pyx_empty_tuple, __pyx_kp_s_raiser_pyx, __pyx_n_s_raiseException, 17, __pyx_empty_bytes); if (unlikely(!__pyx_codeobj_)) __PYX_ERR(0, 17, __pyx_L1_error)
        |                                                                                                                                                                                                                                   ^~~~~~~~~~~~~~~~~~~~~~~~
        |                                                                                                                                                                                                                                   |
        |                                                                                                                                                                                                                                   PyObject * {aka struct _object *}
  src/twisted/test/raiser.c:333:69: note: in definition of macro ‘__Pyx_PyCode_New’
    333 |           PyCode_New(a, p, k, l, s, f, code, c, n, v, fv, cell, fn, name, fline, lnos)
        |                                                                     ^~~~
  In file included from /home/hawkowl/opt/py3.8/include/python3.8/compile.h:5,
                   from /home/hawkowl/opt/py3.8/include/python3.8/Python.h:138,
                   from src/twisted/test/raiser.c:4:
  /home/hawkowl/opt/py3.8/include/python3.8/code.h:122:28: note: expected ‘int’ but argument is of type ‘PyObject *’ {aka ‘struct _object *’}
    122 | PyAPI_FUNC(PyCodeObject *) PyCode_New(
        |                            ^~~~~~~~~~
  src/twisted/test/raiser.c:1306:253: warning: passing argument 15 of ‘PyCode_New’ makes pointer from integer without a cast [-Wint-conversion]
   1306 |   __pyx_codeobj_ = (PyObject*)__Pyx_PyCode_New(0, 0, 0, 0, 0, CO_OPTIMIZED|CO_NEWLOCALS, __pyx_empty_bytes, __pyx_empty_tuple, __pyx_empty_tuple, __pyx_empty_tuple, __pyx_empty_tuple, __pyx_empty_tuple, __pyx_kp_s_raiser_pyx, __pyx_n_s_raiseException, 17, __pyx_empty_bytes); if (unlikely(!__pyx_codeobj_)) __PYX_ERR(0, 17, __pyx_L1_error)
        |                                                                                                                                                                                                                                                             ^~
        |                                                                                                                                                                                                                                                             |
        |                                                                                                                                                                                                                                                             int
  src/twisted/test/raiser.c:333:75: note: in definition of macro ‘__Pyx_PyCode_New’
    333 |           PyCode_New(a, p, k, l, s, f, code, c, n, v, fv, cell, fn, name, fline, lnos)
        |                                                                           ^~~~~
  In file included from /home/hawkowl/opt/py3.8/include/python3.8/compile.h:5,
                   from /home/hawkowl/opt/py3.8/include/python3.8/Python.h:138,
                   from src/twisted/test/raiser.c:4:
  /home/hawkowl/opt/py3.8/include/python3.8/code.h:122:28: note: expected ‘PyObject *’ {aka ‘struct _object *’} but argument is of type ‘int’
    122 | PyAPI_FUNC(PyCodeObject *) PyCode_New(
        |                            ^~~~~~~~~~
  src/twisted/test/raiser.c:333:11: error: too many arguments to function ‘PyCode_New’
    333 |           PyCode_New(a, p, k, l, s, f, code, c, n, v, fv, cell, fn, name, fline, lnos)
        |           ^~~~~~~~~~
  src/twisted/test/raiser.c:1306:31: note: in expansion of macro ‘__Pyx_PyCode_New’
   1306 |   __pyx_codeobj_ = (PyObject*)__Pyx_PyCode_New(0, 0, 0, 0, 0, CO_OPTIMIZED|CO_NEWLOCALS, __pyx_empty_bytes, __pyx_empty_tuple, __pyx_empty_tuple, __pyx_empty_tuple, __pyx_empty_tuple, __pyx_empty_tuple, __pyx_kp_s_raiser_pyx, __pyx_n_s_raiseException, 17, __pyx_empty_bytes); if (unlikely(!__pyx_codeobj_)) __PYX_ERR(0, 17, __pyx_L1_error)
        |                               ^~~~~~~~~~~~~~~~
  In file included from /home/hawkowl/opt/py3.8/include/python3.8/compile.h:5,
                   from /home/hawkowl/opt/py3.8/include/python3.8/Python.h:138,
                   from src/twisted/test/raiser.c:4:
  /home/hawkowl/opt/py3.8/include/python3.8/code.h:122:28: note: declared here
    122 | PyAPI_FUNC(PyCodeObject *) PyCode_New(
        |                            ^~~~~~~~~~
  src/twisted/test/raiser.c: In function ‘__Pyx_CreateCodeObjectForTraceback’:
  src/twisted/test/raiser.c:2522:9: warning: passing argument 14 of ‘PyCode_New’ makes integer from pointer without a cast [-Wint-conversion]
   2522 |         py_funcname,  /*PyObject *name,*/
        |         ^~~~~~~~~~~
        |         |
        |         PyObject * {aka struct _object *}
  src/twisted/test/raiser.c:333:69: note: in definition of macro ‘__Pyx_PyCode_New’
    333 |           PyCode_New(a, p, k, l, s, f, code, c, n, v, fv, cell, fn, name, fline, lnos)
        |                                                                     ^~~~
  In file included from /home/hawkowl/opt/py3.8/include/python3.8/compile.h:5,
                   from /home/hawkowl/opt/py3.8/include/python3.8/Python.h:138,
                   from src/twisted/test/raiser.c:4:
  /home/hawkowl/opt/py3.8/include/python3.8/code.h:122:28: note: expected ‘int’ but argument is of type ‘PyObject *’ {aka ‘struct _object *’}
    122 | PyAPI_FUNC(PyCodeObject *) PyCode_New(
        |                            ^~~~~~~~~~
  src/twisted/test/raiser.c:2523:9: warning: passing argument 15 of ‘PyCode_New’ makes pointer from integer without a cast [-Wint-conversion]
   2523 |         py_line,
        |         ^~~~~~~
        |         |
        |         int
  src/twisted/test/raiser.c:333:75: note: in definition of macro ‘__Pyx_PyCode_New’
    333 |           PyCode_New(a, p, k, l, s, f, code, c, n, v, fv, cell, fn, name, fline, lnos)
        |                                                                           ^~~~~
  In file included from /home/hawkowl/opt/py3.8/include/python3.8/compile.h:5,
                   from /home/hawkowl/opt/py3.8/include/python3.8/Python.h:138,
                   from src/twisted/test/raiser.c:4:
  /home/hawkowl/opt/py3.8/include/python3.8/code.h:122:28: note: expected ‘PyObject *’ {aka ‘struct _object *’} but argument is of type ‘int’
    122 | PyAPI_FUNC(PyCodeObject *) PyCode_New(
        |                            ^~~~~~~~~~
  src/twisted/test/raiser.c:333:11: error: too many arguments to function ‘PyCode_New’
    333 |           PyCode_New(a, p, k, l, s, f, code, c, n, v, fv, cell, fn, name, fline, lnos)
        |           ^~~~~~~~~~
  src/twisted/test/raiser.c:2508:15: note: in expansion of macro ‘__Pyx_PyCode_New’
   2508 |     py_code = __Pyx_PyCode_New(
        |               ^~~~~~~~~~~~~~~~
  In file included from /home/hawkowl/opt/py3.8/include/python3.8/compile.h:5,
                   from /home/hawkowl/opt/py3.8/include/python3.8/Python.h:138,
                   from src/twisted/test/raiser.c:4:
  /home/hawkowl/opt/py3.8/include/python3.8/code.h:122:28: note: declared here
    122 | PyAPI_FUNC(PyCodeObject *) PyCode_New(
        |                            ^~~~~~~~~~
  error: command 'gcc' failed with exit status 1
  ----------------------------------------
Searchable metadata
trac-id__9674 9674
type__defect defect
reporter__hawkowl hawkowl
priority__normal normal
milestone__Python_3_8_Support Python 3.8 Support
branch__ 
branch_author__ 
status__closed closed
resolution__fixed fixed
component__core core
keywords__None None
time__1563633748957786 1563633748957786
changetime__1563635467822188 1563635467822188
version__None None
owner__hawkowl hawkowl

@twisted-trac
Copy link
Author

hawkowl's avatar @hawkowl set owner to @hawkowl

Since this is 100% machine generated mechanical changes, I'm going to review the changes that cython did :)

@twisted-trac
Copy link
Author

hawkowl's avatar @hawkowl commented

[I verified that Python 3.8.0b2 now did not compile error]

@twisted-trac
Copy link
Author

hawkowl's avatar @hawkowl set status to closed

In changeset b695526

#!CommitTicketReference repository="" revision="b6955269d886279e9e1cd74cd230ab0835ba2847"
Merge 9674-raiser-c: Regenerate twisted/test/raiser.c for Python 3.8.0b2

Author: cython
Reviewer: hawkowl
Fixes: ticket:9674

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants