Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raiser.c should be regenerated with Cython 3.0a0 #9640

Closed
twisted-trac opened this issue May 14, 2019 · 5 comments
Closed

raiser.c should be regenerated with Cython 3.0a0 #9640

twisted-trac opened this issue May 14, 2019 · 5 comments

Comments

@twisted-trac
Copy link

eclipseo's avatar @eclipseo reported
Trac ID trac#9640
Type defect
Created 2019-05-14 15:01:53Z

In Fedora Linux, we are currently rebuilding our Python stack with Python 3.8.

In Python 3.8 alpha 4, the PyCode_New() signature changed due to PEP 570:
python/cpython@8c77b8c

As such the code generated by previous Cython are now failing with a too few arguments error for PyCode_New(), see bug cython/cython#2938

This was fixed in Cython master: cython/cython@d22678c

It will be backported in Cython 0.29.x but in the meantime we can use Cython master to regenerate raiser.c for use with Python >= 3.8a4

Searchable metadata
trac-id__9640 9640
type__defect defect
reporter__eclipseo eclipseo
priority__normal normal
milestone__None None
branch__ 
branch_author__ 
status__closed closed
resolution__fixed fixed
component__core core
keywords__None None
time__1557846113835664 1557846113835664
changetime__1558248273345831 1558248273345831
version__None None
owner__hawkowl hawkowl
cc__hawkowl
@twisted-trac
Copy link
Author

eclipseo's avatar @eclipseo commented

#1140

@twisted-trac
Copy link
Author

glyph's avatar @glyph commented

hawkie, how close are we to deleting raiser.c entirely? If it's going to take more than a couple of days we should probably just land this in the interim.

@twisted-trac
Copy link
Author

hawkowl's avatar @hawkowl commented

Agreed.

@twisted-trac
Copy link
Author

hawkowl's avatar @hawkowl set owner to @hawkowl

@twisted-trac
Copy link
Author

hawkowl's avatar @hawkowl set status to closed

In changeset c1e5dd3

#!CommitTicketReference repository="" revision="c1e5dd3ddeb926ab5bd60e950ea56dee1eb5660f"
Merge 9640-eclipseo-regenerate-raiser: Regenerate raiser.c

Author: eclipseo
Reviewer: hawkowl
Fixes: ticket:9640

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants