Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Componentized.addComponent docstring has wrong return value #9637

Closed
twisted-trac opened this issue May 7, 2019 · 3 comments
Closed

Componentized.addComponent docstring has wrong return value #9637

twisted-trac opened this issue May 7, 2019 · 3 comments

Comments

@twisted-trac
Copy link

Hnasar's avatar @Hnasar reported
Trac ID trac#9637
Type defect
Created 2019-05-07 19:46:45Z

Since commit 0961531 back in 2002, the docstring has incorrectly
stated that this function returns something.

Searchable metadata
trac-id__9637 9637
type__defect defect
reporter__Hnasar Hnasar
priority__low low
milestone__None None
branch__ 
branch_author__ 
status__closed closed
resolution__fixed fixed
component__core core
keywords__None None
time__1557258405121237 1557258405121237
changetime__1557346580975939 1557346580975939
version__None None
owner__glyph glyph
cc__Hnasar
@twisted-trac
Copy link
Author

Hnasar's avatar @Hnasar commented

Pull request here #1136

@twisted-trac
Copy link
Author

glyph's avatar @glyph set owner to @glyph

Thanks for your contribution, Hashem! Reviewed on Github; I'll land this.

@twisted-trac
Copy link
Author

glyph's avatar @glyph set status to closed

In changeset 5cfbc76

#!CommitTicketReference repository="" revision="5cfbc765c30fde310ca0140eb895ee2a0cbb724e"
Merge pull request #1136 from Hnasar/9637-addcomponent-return-value

Author: Hnasar

Reviewer: glyph

Fixes: ticket:9637

Remove incorrect documentation for Componentized.addComponent's return type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants