Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factor reactor name-resolution implementations out of ReactorBase for easier re-use #9632

Closed
twisted-trac opened this issue Apr 25, 2019 · 2 comments

Comments

@twisted-trac
Copy link

exarkun's avatar @exarkun reported
Trac ID trac#9632
Type enhancement
Created 2019-04-25 14:17:53Z

ReactorBase implements IReactorPluggableNameResolver and IReactorPluggableResolver. The implementations are entirely self-contained and consist essentially of boring bookkeeping logic.

If the implementation were factored into a stand-alone class then it could be mixed in to other reactor implementations quite easily. Since name resolution is increasingly a requirement of basic functionality (due to HostnameEndpoint) it would be excellent to provide this mixin as a helper rather than forcing everyone to re-implement the same boring logic.

Searchable metadata
trac-id__9632 9632
type__enhancement enhancement
reporter__exarkun exarkun
priority__normal normal
milestone__None None
branch__ 
branch_author__ 
status__closed closed
resolution__fixed fixed
component__core core
keywords__None None
time__1556201873701187 1556201873701187
changetime__1556647699027309 1556647699027309
version__None None
owner__Jean_Paul_Calderone__exarkun_____ Jean-Paul Calderone <exarkun@...>

@twisted-trac
Copy link
Author

exarkun's avatar @exarkun commented

#1130

@twisted-trac
Copy link
Author

exarkun's avatar @exarkun set owner to @exarkun
@exarkun set status to closed

In changeset 6cc6af6

#!CommitTicketReference repository="" revision="6cc6af6c624cd61ffc2bb4328c380dd972569b6e"
Merge pull request #1130 from twisted/9632.factor-out-pluggable-resolver-reactor

Factor out pluggable resolver reactor implementation

Author: exarkun
Reviewer: meejah
Fixes: ticket:9632

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants