Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve coverage configuration in CI #9625

Closed
twisted-trac opened this issue Apr 13, 2019 · 2 comments
Closed

improve coverage configuration in CI #9625

twisted-trac opened this issue Apr 13, 2019 · 2 comments

Comments

@twisted-trac
Copy link

glyph's avatar @glyph reported
Trac ID trac#9625
Type enhancement
Created 2019-04-13 06:49:43Z

this is just a build config change but all the static checkers fail without a trac newsfile id, so, might as well write down what I'm doing:

  • It looks like despite their fairly lame landing page, coveralls might have leapfrogged codecov in reliability again, so I'd like to try out using them. (automat uses coveralls and it actually seems substantially more reliable than the various projects I work on that use codecov)
  • we have a ton of legacy cruft in tox.ini
  • macOS builders on travis weren't sending coverage data
  • having coveralls report build status and not having buildbots send coverage data means we're more likely to get a reliable baseline from our various cloud services; we can still report coverage to codecov too
Searchable metadata
trac-id__9625 9625
type__enhancement enhancement
reporter__glyph glyph
priority__normal normal
milestone__None None
branch__ 
branch_author__ 
status__closed closed
resolution__fixed fixed
component__core core
keywords__None None
time__1555138183297420 1555138183297420
changetime__1555303335513681 1555303335513681
version__None None
owner__Glyph__glyph_____ Glyph <glyph@...>

@twisted-trac
Copy link
Author

glyph's avatar @glyph commented

#1129

@twisted-trac
Copy link
Author

glyph's avatar @glyph set owner to @glyph
@glyph set status to closed

In changeset 17380c9

#!CommitTicketReference repository="" revision="17380c9a7a50e2bdad774a6699f0b8bbebc5f5e3"
Merge pull request #1129 from glyph/enhanced-coverage-configuration

Author: glyph

Reviewer: glyph

Fixes: ticket:9625

This uploads coverage data to both codecov and coveralls in order for us to compare the present state of the art on these two services, in a way which is (hopefully) backwards compatible to buildbot environments that are a little trickier to update.

This leaves codecov receiving coverage from all buildbots, but uploads coveralls only from our cloud CI environments, hopefully providing us with a more stable coverage metric that contributors can score themselves against.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants