paul kehrer can't follow basic instructions

[twisted-trac]

	@glyph reported
Trac ID	trac#9614
Type	defect
Created	2019-04-06 05:22:58Z

NPNAndALPNAbsentTests skip iff both are absent

Previously these tests only skipped if they failed to detect NPN on the assumption that ALPN would never be present if NPN was missing. However, NPN is deprecated and we'd like to remove it from cryptography/pyOpenSSL so this test needs to be smarter.

refs pyca/cryptography#4765

Searchable metadata

trac-id__9614 9614
type__defect defect
reporter__glyph glyph
priority__normal normal
milestone__None None
branch__ 
branch_author__ 
status__closed closed
resolution__fixed fixed
component__core core
keywords__None None
time__1554528178991234 1554528178991234
changetime__1554668249446479 1554668249446479
version__None None
owner__Glyph__glyph_____ Glyph <glyph@...>

[twisted-trac]

	@glyph commented

PR at #1121 which subsumes the original one at #1120

[twisted-trac]

	@glyph commented

Since this was actually submitted by Paul Kehrer, I can review it.

And I do review it.

"Looks good to me".

[twisted-trac]

	@glyph set owner to @glyph @glyph set status to closed

In changeset 24e48fc

#!CommitTicketReference repository="" revision="24e48fc359d52e8f578714fe232fe8e85c551d7e"
Merge pull request #1121 from glyph/9614-npnalpn-skip

Author: reaperhulk

Reviewer: glyph

Fixes: ticket:9614

NPNAndALPNAbsentTests skip iff both are absent

Previously these tests only skipped if they failed to detect NPN on the assumption that ALPN would never be present if NPN was missing. However, NPN is deprecated and we'd like to remove it from cryptography/pyOpenSSL so this test needs to be smarter.

refs ​https://github.com/pyca/cryptography/pull/4765