Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Twisted does not have the correct minimum cryptography dependency #9592

Closed
twisted-trac opened this issue Mar 2, 2019 · 4 comments
Closed

Comments

@twisted-trac
Copy link

ryban's avatar @ryban reported
Trac ID trac#9592
Type release blocker: regression
Created 2019-03-02 01:38:32Z

The fix for #9584 depends on cryptography>=2.5 but the current dependency is >=1.5.

Traceback (most recent call last):
  File "env/local/lib/python2.7/site-packages/twisted/conch/ssh/transport.py", line 703, in dataReceived
    self.dispatchMessage(messageNum, packet[1:])
  File "env/local/lib/python2.7/site-packages/twisted/conch/ssh/transport.py", line 721, in dispatchMessage
    f(payload)
  File "env/local/lib/python2.7/site-packages/twisted/conch/ssh/transport.py", line 1603, in ssh_KEXINIT
    serialization.Encoding.X962,
  File "env/local/lib/python2.7/site-packages/enum/__init__.py", line 390, in __getattr__
    raise AttributeError(name)
AttributeError: X962
Searchable metadata
trac-id__9592 9592
type__release_blocker__regression release blocker: regression
reporter__ryban ryban
priority__normal normal
milestone__None None
branch__ 
branch_author__ 
status__closed closed
resolution__fixed fixed
component__core core
keywords__None None
time__1551490712145633 1551490712145633
changetime__1554626790106379 1554626790106379
version__None None
owner__hawkowl hawkowl
cc__twm
@twisted-trac
Copy link
Author

hawkowl's avatar @hawkowl commented

PR: #1111

@twisted-trac
Copy link
Author

twm's avatar @twm set owner to @hawkowl

Looks good. Merge away! #1111 (review)

@twisted-trac
Copy link
Author

hawkowl's avatar @hawkowl set status to closed

In changeset 7849ccd

#!CommitTicketReference repository="" revision="7849ccd3290d2196c0101853ecef23893a520066"
Merge 9592-min-cryptography-bump: Bump Cryptography dependency to 2.5

Author: hawkowl
Reviewer: twm
Fixes: ticket:9592

@twisted-trac
Copy link
Author

hawkowl's avatar @hawkowl commented

In changeset 2c739f7

#!CommitTicketReference repository="" revision="2c739f738987546070dd8e3d3f14264603865d58"
Merge 9592-min-cryptography-bump: Bump Cryptography dependency to 2.5

Author: hawkowl
Reviewer: twm
Fixes: ticket:9592

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants