Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PyHamcrest is listed as requirement, but it's only a test requirement #9509

Closed
twisted-trac opened this issue Aug 14, 2018 · 7 comments
Closed

Comments

@twisted-trac
Copy link

doko42's avatar @doko42 reported
Trac ID trac#9509
Type defect
Created 2018-08-14 19:12:44Z
Branch https://github.com/twisted/twisted/tree/9509-extra-extra-read-all-about-hamcrest

PyHamcrest is listed as requirement, but it's only a test requirement. Please change that in the setup.py file.

this is seen in 18.7.0.

Searchable metadata
trac-id__9509 9509
type__defect defect
reporter__doko42 doko42
priority__normal normal
milestone__None None
branch__9509_extra_extra_read_all_about_hamcrest 9509-extra-extra-read-all-about-hamcrest
branch_author__ 
status__closed closed
resolution__fixed fixed
component__core core
keywords__review review
time__1534273964226296 1534273964226296
changetime__1603174184579904 1603174184579904
version__None None
owner__Tom_Most__twm_____ Tom Most <twm@...>

@twisted-trac
Copy link
Author

doko42's avatar @doko42 commented

this is seen in 18.7.0.

@twisted-trac
Copy link
Author

twm's avatar @twm set owner to @twm
@twm set status to assigned

@twisted-trac
Copy link
Author

twm's avatar @twm removed owner
@twm set status to new

Pull request: #1377

@twisted-trac
Copy link
Author

glyph's avatar @glyph set owner to @twm

Reply on the PR; let's add a test extra.

@twisted-trac
Copy link
Author

twm's avatar @twm commented

Updated PR with a test extra.

@twisted-trac
Copy link
Author

twm's avatar @twm removed owner

@twisted-trac
Copy link
Author

twm's avatar @twm set owner to @twm
@twm set status to closed

In changeset 7211555

#!CommitTicketReference repository="" revision="7211555837acc332d29339f71ffdb405fb48efcd"
Merge pull request #1377 from twisted/9509-extra-extra-read-all-about-hamcrest

Author: twm
Reviewer: glyph, adiroiban
Fixes: ticket:9509

Move PyHamcrest dependency to [test] extra

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants