Support running tests on MSVS Hosted

[twisted-trac]

	@hawkowl reported
Trac ID	trac#9454
Type	enhancement
Created	2018-05-16 21:09:12Z

https://twistedmatrix.visualstudio.com

Searchable metadata

trac-id__9454 9454
type__enhancement enhancement
reporter__hawkowl hawkowl
priority__normal normal
milestone__None None
branch__ 
branch_author__ 
status__closed closed
resolution__fixed fixed
component__core core
keywords__None None
time__1526504952620181 1526504952620181
changetime__1561241352452853 1561241352452853
version__None None
owner__Amber_Brown__hawkowl_____ Amber Brown <hawkowl@...>

[twisted-trac]

	@hawkowl set owner to @hawkowl @hawkowl set status to closed

In changeset 8d75ba5

#!CommitTicketReference repository="" revision="8d75ba5bcbafdc9fd35d8400c526db2f5f14c62e"
Merge 9454-msvs: Support Azure Pipelines

Author: hawkowl
Reviewer: hawkowl
Fixes: ticket:9454

[twisted-trac]

	@glyph commented

exarkun had some questions on IRC, and I don't think we wrote this down anywhere, so here are the answers, for posterity:

What is the actual point of the ticket?

The goal of the ticket is mainly to remove redundant configuration from other CI systems for builds that had already been moved to Azure Pipelines to avoid slowing down the build. There were a couple of tweaks necessary to skip side-effect-y tests that don't work in the Azure network environment; we might want to file follow-up tickets for some testing strategy for this code if Azure is going to be our only environment. At the very least, we should tell the Azure support folks about it.

The point of moving to Azure Pipelines (as opposed to Travis or Circle or Appveyor) is that it's many times faster, their support is more responsive, and can provide us with both considerably more computational resources as well as keeping the builds for all of our different supported platforms in one place.

Where is the Azure pipeline configuration?

It's hosted within Azure Pipelines itself right now, in the web UI there.

As Amber recently mentioned on the list, at least at the time we transitioned to it, YAML configuration couldn't express the intersection of features that we wanted to use. I sent a follow-up message because I couldn't quite figure out if she was saying it's supported now or not.

What is the deal with a self-reviewed change?

In-person at PyCon, Amber and I discussed it; given that she was working in-person with the Azure folks, and the configuration wasn't going to be happening in the repo (and getting code reviewed etc) anyway, to consider any necessary matching changes to the build configs pre-approved because the Azure configuration needed to take place in Azure directly, and no changes to the Twisted code (beyond a hook for test skips) were going to be occurring. Indeed, not even the local test configuration (tox.ini) was changed.

I do wish that hawkie had written down what she did, but then, I could have written it down too :). (So here I am, writing it down.)