Re-enable macOS builds on CircleCI

[twisted-trac]

	@adiroiban reported
Trac ID	trac#9445
Type	enhancement
Created	2018-05-13 14:07:28Z

Now we have 1000h of macOS build on circleCI.

With this, we might make it for 1 month

Searchable metadata

trac-id__9445 9445
type__enhancement enhancement
reporter__adiroiban adiroiban
priority__normal normal
milestone__None None
branch__ 
branch_author__ 
status__closed closed
resolution__fixed fixed
component__core core
keywords__review review
time__1526220448543314 1526220448543314
changetime__1551591914981359 1551591914981359
version__None None
owner__Glyph__glyph_____ Glyph <glyph@...>
cc__altendky

[twisted-trac]

	@adiroiban set owner to @adiroiban @adiroiban set status to assigned

[twisted-trac]

	@adiroiban removed owner @adiroiban set status to new

#1011

[twisted-trac]

	@glyph set owner to @adiroiban

Hi Adi,

I keep coming back to this ticket and trying to figure out what is going on, but I find I don't have enough information to review this.

Can you explain a few things about this so that I can confidently say it should be merged?

1. What was the previous limit?
2. How quickly did we exhaust it?
3. If we require more quota, who do we ask?
4. If we reqiure more quota, how likely is it to be approved?
5. Are there any out-of-band configuration changes that we need to make in order for this to work?

Also, if you could resolve the conflicts that have crept in so that it can be easily merged that would be great.

[twisted-trac]

	@adiroiban removed owner

Hi,

Thanks for the review.

I no longer have time for this... and with 4 months to review this looks like a low priority to the rest of the team.
For me, it was very important for not commiters to be able to get a macOS build for their PR.

For 1 and 2 see https://twistedmatrix.com/pipermail/twisted-python/2018-April/031912.html

It depends on how active are the Twisted devs.

I hope this time it can be enough.

I did not spend much time with this research as is easy to enable/disable and when we run out of quota, nothing bad happens.

---

3 and 4. billing@... .

In my communication with Circle CI I added you and Jean-Paul to CC. See if you have an email "macOS Seed Plan for Twisted Open Source Project" started on the 19th of March 2018.

I don't know if we can receive more... we already got an extension from 500 to 1000.

---

5. I don't think so. This was already working, and it was paused while we were waiting to receive ore quote.

[twisted-trac]

	@altendky commented

New PR with trunk merged. @glyph was there more you were looking for?

#1056

[twisted-trac]

	@altendky set owner to @glyph

[twisted-trac]

	@altendky commented

With 3.7 supported now we should probably make both the Circle OSX builds required before closing this ticket. As in, GitHub requires their success for PRs.

[twisted-trac]

	@glyph removed owner

New PR with trunk merged. @glyph was there more you were looking for?

I think this addresses my concerns, but I haven't had time for a full review. I specifically don't need to approve this - any qualified reviewer can look at my concerns, see if the questions are addressed, and approve away.

[twisted-trac]

	@glyph set owner to @glyph @glyph set status to closed

In changeset c20f019

#!CommitTicketReference repository="" revision="c20f01967702c6941ca796cc4837791754944c1c"
Merge pull request #1056 from altendky/9445-altendky-reenable-macos-circleci

Author: altendky, adiroiban

Reviewer: glyph

Fixes: ticket:9445

Re-enable macOS continuous integration configuration on CircleCI.