Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate twisted.news #9405

Closed
twisted-trac opened this issue Apr 2, 2018 · 9 comments
Closed

Deprecate twisted.news #9405

twisted-trac opened this issue Apr 2, 2018 · 9 comments

Comments

@twisted-trac
Copy link

hawkowl's avatar @hawkowl reported
Trac ID trac#9405
Type task
Created 2018-04-02 08:23:02Z

Currently, t.news has below-Twisted standards of code coverage, implementation (with one huuuuge ad-hoc state machine), comments, tests, etc. It's also not had any changes to the bulk of its code for 14 years, apart from what appears to be code removal 6 years ago and a handful of "twisted-wide" mechanical syntax changes. It's also unlikely to ever be ported to Python 3 unless someone were to improve the former issues (since the port would require 100%-as-possible code coverage).

I propose deprecating twisted.news on the condition that it doesn't have a maintainer, and un-deprecating it if a user of the code steps up to maintain it and brings it into line (vs one of the current development team taking on work keeping an ancient protocol on life support). If nobody steps up, then we remove it at the end of the deprecation period and encourage any remaining users to either pin to old Twisteds or simply vendor the code in their own codebase.

Searchable metadata
trac-id__9405 9405
type__task task
reporter__hawkowl hawkowl
priority__normal normal
milestone__None None
branch__ 
branch_author__ 
status__closed closed
resolution__fixed fixed
component__news news
keywords__None None
time__1522657382254992 1522657382254992
changetime__1585366199047213 1585366199047213
version__None None
owner__hawkowl hawkowl

@twisted-trac
Copy link
Author

hawkowl's avatar @hawkowl commented

PR: #1144

@twisted-trac
Copy link
Author

glyph's avatar @glyph set owner to @hawkowl

Can you raise this on the mailing list first? Dropping a major component like this should have some visibility.

If we do go ahead with this, we should delete its prominent mention from https://twistedmatrix.com/trac/wiki/SuccessStories#Mailman

@twisted-trac
Copy link
Author

glyph's avatar @glyph commented
[23:54:07]  <kenaan>	glyph reviewed <https://tm.tl/#9405> - Deprecate twisted.news (assigned to hawkowl)
[23:55:07]  <hawkowl>	glyph, but i did tho
[23:55:08]  <hawkowl>	2/4/18, 3:23 am
[23:56:53]  <hawkowl>	https://twistedmatrix.com/pipermail/twisted-python/2018-April/031882.html
[23:57:00]  <hawkowl>	I actually sent it last year and nobody responded
[23:58:11]  <hawkowl>	glyph, which maybe makes me guess that nobody actually cares
[23:58:28]  <hawkowl>	(I was going through tickets on my ancient todolist which is why I'm doing stuff now)

@twisted-trac
Copy link
Author

glyph's avatar @glyph removed owner

@twisted-trac
Copy link
Author

glyph's avatar @glyph commented

Here is the aforementioned (non-)discussion as a link: https://twistedmatrix.com/pipermail/twisted-python/2018-April/031882.html

@twisted-trac
Copy link
Author

glyph's avatar @glyph commented

Reviewed over at #1144 (review).

I'll go delete the relevant success story.

@twisted-trac
Copy link
Author

glyph's avatar @glyph set owner to @hawkowl

@twisted-trac
Copy link
Author

hawkowl's avatar @hawkowl set status to closed

In changeset 636b364

#!CommitTicketReference repository="" revision="636b36474254c1e9cf8c8bdace1604ed2a72e87d"
Merge 9405-dep-tnews: Deprecate twisted.news

Author: hawkowl
Reviewer: glyph
Fixes: ticket:9405

@twisted-trac
Copy link
Author

hawkowl's avatar @hawkowl commented

In changeset d33c626

#!CommitTicketReference repository="" revision="d33c626328ffc34a51b00a836282d91ed46352c7"
Merge 9405-dep-tnews: Deprecate twisted.news

Author: hawkowl
Reviewer: glyph
Fixes: ticket:9405

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants