Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Documentation to Cover Deploying Twisted Application as Python Packages #9243

Closed
twisted-trac opened this issue Jul 30, 2017 · 8 comments

Comments

@twisted-trac
Copy link

westfeld's avatar @westfeld reported
Trac ID trac#9243
Type enhancement
Created 2017-07-30 20:18:57Z

I would like to suggest to extend the documentation for writing a twistd plugin ([http://twistedmatrix.com/documents/current/core/howto/tap.html]) to include deploying the plugin using standard python packaging and installing it via pip.

I would like to include the potential pitfall of how to structure the package correctly and how to use setup.py to install the package.

see #852

Searchable metadata
trac-id__9243 9243
type__enhancement enhancement
reporter__westfeld westfeld
priority__low low
milestone__None None
branch__ 
branch_author__ 
status__closed closed
resolution__fixed fixed
component__core core
keywords__None None
time__1501445937327162 1501445937327162
changetime__1595138044545678 1595138044545678
version__None None
owner__Tom_Most__twm_____ Tom Most <twm@...>

@twisted-trac
Copy link
Author

westfeld's avatar @westfeld commented

My ticket has not been reviewed or accepted yet. Am I doing anything wrong? Is there anything missing?

As a first-time contributor it would be nice to know.

@twisted-trac
Copy link
Author

exarkun's avatar @exarkun set owner to @westfeld

You did everything right as far as I can tell. Including asking for attention when the issue got none.

@twisted-trac
Copy link
Author

glyph's avatar @glyph commented

It looks like you addressed all the feedback, but never re-submitted this for review. I'm assuming you'd still like this to be integrated, and I'm submitting it for review myself.

@twisted-trac
Copy link
Author

twm's avatar @twm set owner to @twm
@twm set status to assigned

@twisted-trac
Copy link
Author

twm's avatar @twm set owner to @westfeld
@twm set status to new

Reviewed on GitHub: #852 (review)

@twisted-trac
Copy link
Author

westfeld's avatar @westfeld removed owner

@twisted-trac
Copy link
Author

twm's avatar @twm commented

Approved: #852 (review)

@twisted-trac
Copy link
Author

twm's avatar @twm set owner to @twm
@twm set status to closed

In changeset ac26227

#!CommitTicketReference repository="" revision="ac26227b746bb4d842233557ca7f59890d4b219a"
Merge pull request #852 from westfeld/9243-westfeld-add-deployment-docs-pip

Author: westfeld
Reviewer: exarkun, twm
Fixes: ticket:9243

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants