DelayedCall.__str__ assumes that things with __name__s always have func_names

[twisted-trac]

	@Julian reported
Trac ID	trac#9061
Type	defect
Created	2017-02-27 16:06:26Z

(They do not, they can be classes or other fun things).

See e.g.:

from twisted.internet import reactor
from twisted.trial.unittest import TestCase
class TestTest(TestCase):
    def test_it_blows_up(self):
        reactor.callLater(10, int)

twisted/src/twisted/internet/base.py

Lines 192 to 193 in b276c7f

	elif hasattr(self.func, '__name__'):
	func = self.func.func_name

The comment there possibly means that this should just be done "properly" via #6066 rather than fixing this specific issue.

Searchable metadata

trac-id__9061 9061
type__defect defect
reporter__Julian Julian
priority__normal normal
milestone__None None
branch__ 
branch_author__ 
status__new new
resolution__None None
component__core core
keywords__None None
time__1488211586271757 1488211586271757
changetime__1488211586271757 1488211586271757
version__None None
owner__None None

[exarkun]

It looks like this was introduced in 09c9169 for #6065. Then it was fixed (maybe not "properly") in fadb582 as part of #1570 for #10155.

#6066 remains valid because the logic is just inline in DelayedCall.__repr__.