Failure’s frames carry no module information

[twisted-trac]

	@hynek reported
Trac ID	trac#7796
Type	enhancement
Created	2015-02-24 09:10:52Z

I was investigating why Sentry always showed me ? for culprits (= modules) and I dove deep into both Twisted and raven (the Python reporting client) and found the reason: twisted.python.failure._Frame has an empty f_globals and raven determines the name of the module by looking at f_globals["__name__"] which seems reasonable.

Is there a reason we don’t set this value other than it hasn’t been done yet?

Searchable metadata

trac-id__7796 7796
type__enhancement enhancement
reporter__hynek hynek
priority__normal normal
milestone__ 
branch__ 
branch_author__ 
status__closed closed
resolution__duplicate duplicate
component__core core
keywords__review review
time__1424769052740616 1424769052740616
changetime__1646554270309167 1646554270309167
version__None None
owner__None None
cc__hynek

[twisted-trac]

	@exarkun commented

Presumably there was no perceived need for this information. This is supported by the _Traceback docstring:

        Note that                                                                            
        although frames generally include locals and globals, this information                                                                         
        is not kept by this object, since locals and globals are not used in                                                                           
        standard tracebacks.

(Hooray, useful documentation.)

I don't see what would hurt about putting some of the simple data from the actual frame into the fake frame (documenting the motivation behind each piece, probably).

[twisted-trac]

	@pdunning-xilinx commented

I've run into this when doing post mortem debugging.
It results in the variables appearing as not defined.

As, when the Failure object is cleaned (Failure.cleanFailure()), _safeReprVars() is called on the locals and globals, we can only save string versions of the variables at that point. That's still better than nothing from a debugging perspective.

[twisted-trac]

	@pdunning-xilinx commented

Patch for review #1680

[twisted-trac]

	@adiroiban set status to closed

Done via the PR for #9599

#1684