t.c.ssh.filetransferserver.FileTransferServer.packet_READ with unhandled error

[adiroiban]

If the ID if the SSH file requested to read is not found, the current code will try to call self._ebRead(failure.Failure(KeyError()), requestId) ... but FileTransferServer._ebRead is not defined

twisted/src/twisted/conch/ssh/filetransfer.py

Lines 237 to 254 in 02a2b65

	def packet_READ(self, data):
	requestId = data[:4]
	data = data[4:]
	handle, data = getNS(data)
	(offset, length), data = struct.unpack("!QL", data[:12]), data[12:]
	assert data == b"", f"still have data in READ: {data!r}"
	if handle not in self.openFiles:
	self._ebRead(failure.Failure(KeyError()), requestId)
	else:
	fileObj = self.openFiles[handle]
	d = defer.maybeDeferred(fileObj.readChunk, offset, length)
	d.addCallback(self._cbRead, requestId)
	d.addErrback(self._ebStatus, requestId, b"read failed")
	def _cbRead(self, result, requestId):
	if result == b"": # Python's read will return this for EOF
	raise EOFError()
	self.sendPacket(FXP_DATA, requestId + NS(result))

A quick fix... not yet tested

    def packet_READ(self, data):
        requestId = data[:4]
        data = data[4:]
        handle, data = getNS(data)
        (offset, length), data = struct.unpack("!QL", data[:12]), data[12:]
        assert data == b"", f"still have data in READ: {data!r}"
        if handle not in self.openFiles:
            self._ebStatus(failure.Failure(KeyError()), requestId, b'file not found')
            return

        fileObj = self.openFiles[handle]
        d = defer.maybeDeferred(fileObj.readChunk, offset, length)
        d.addCallback(self._cbRead, requestId)
        d.addErrback(self._ebStatus, requestId, b"read failed")