Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

t.conch.ssh.SSHServerTransport should have a separate list for server-sig-algs #12107

Open
adiroiban opened this issue Mar 4, 2024 · 0 comments
Labels

Comments

@adiroiban
Copy link
Member

adiroiban commented Mar 4, 2024

The current code is here

if firstKey:
self.sendExtInfo(
[(b"server-sig-algs", b",".join(self.supportedPublicKeys))]
)

server-sig-algs is documented in RFC 8308

This extension is sent by the server and contains a list of public
key algorithms that the server is able to process as part of a
"publickey" authentication request.

The current list is shared between server host keys algorithms and userauth pubkey algorithms.

You might want to have a SSH server that for example only supports ssh-ed25519 and ecdsa-sha2-nistp256 as a host keys... but users should still be allowed to authenticate with an ecdsa-sha2-nistp521 or ssh-rsa key


One option to fix this is to have a separate list of algorithms allowed for userauth pubkey that is sent to server-sig-algs

It can be named SSHServerTransport.supportedSigAlgs

@adiroiban adiroiban added the conch label Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant