Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

automatically generate PRs to upgrade PyPy and CPython in our release process #12086

Open
glyph opened this issue Jan 14, 2024 · 3 comments
Open

Comments

@glyph
Copy link
Member

glyph commented Jan 14, 2024

We have recently ( #12083 ) updated to pinning PyPy version, and we should keep it that way so that buggy pypy upgrades do not disrupt unrelated changes getting landed, but we should have automatic PRs for new versions of PyPy.

I don't think dependabot can generate these and I haven't found anything automatic yet, but a daily cron job to check if the version has changed on the website and try editing the yaml and opening a PR should do the trick.

@adiroiban
Copy link
Member

I don't think pypy breakage is that often.
And if it happens, we can fix it by temporary pinning the previous PyPy version.
The devs from PyPy were quite responsive.

For me, the macos flaky tests are a much bigger issue than PyPy.

@glyph
Copy link
Member Author

glyph commented Jan 15, 2024

For me, the macos flaky tests are a much bigger issue than PyPy.

This is not an issue of prioritization, but, I've been banging on the CFReactor tests to try to understand what's going on there too.

@glyph
Copy link
Member Author

glyph commented Jan 15, 2024

I don't think pypy breakage is that often.
And if it happens, we can fix it by temporary pinning the previous PyPy version.

I don't want new contributors to get test failures that are not related to their change. Everything should be pinned, as a matter of course. PyPy is among the least likely to cause issues, but luckily, it's already pinned so nothing needs to be done there :).

We need a similar pinning & cron job for CPython upgrades as well, so PyPy isn't special here, the example is just recent and so this issue tracks a follow-up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants