Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop service_identity in favor of just verifying with pyOpenSSL #12082

Open
glyph opened this issue Jan 12, 2024 · 0 comments
Open

drop service_identity in favor of just verifying with pyOpenSSL #12082

glyph opened this issue Jan 12, 2024 · 0 comments

Comments

@glyph
Copy link
Member

glyph commented Jan 12, 2024

we decided that one big pile [of garbage] Is better than two little piles, and rather than bring that one up we decided to throw ours down.

— Arlo Gurthrie, "Alice's Restaurant"

We currently verify hostnames using the service_identity python library, but doing this is part of the verification process, which is OpenSSL's job as long as we're using OpenSSL for TLS. We also do weird shenanigans with the info callback rather than just letting verification proceed as normal, and it's generally quite confusing and squirrely, which is bad for security-critical code.

Doing this the right way is blocked by this pyOpenSSL issue, but in a comment there is a reference to the hostname logic in mitmproxy, which just calls the OpenSSL functions directly without waiting for pyOpenSSL to wrap them properly; we might want to do the same thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant