@adiroiban removed owner

Please check the associated branch add see if it make sense.

I have updated the documentation to talk about how to test deprecated module attributes.

I have re-arrange the current docs so that the example about how to run trial so that it fails on warnings has a greater visibility.

Thanks!

	@mesozoic commented

This doesn't quite fix it, I think; test_RequestAvatarId_hashed would still cause an error because it's accessing a deprecated module attribute. It also bothers me to include hard-coded warning strings in our tests.

As you'd requested, I'm going to try to address this in a documentation patch as part of #8368. I'm also going to add a new test helper method, getDeprecatedModuleAttribute, which will retrieve the module attribute and make assertions about its deprecation status.

	@adiroiban commented

Hi mesozoic,
Feel free to push you changed to the associated branch.

My problem was that there were no examples on how to "properly" deprecate and test a class so I went for creating this branch to discuss and document what we agreed.

Cheers

	@rodrigc set owner to @adiroiban

This document is not fully consistent with the docstring in twisted/python/deprecate.py for
how to deprecate fields, methods, classes and modules.

I suggest that both the document and the docstring be made consistent.

	@adiroiban commented

Once comment about testing deprecation.

When we outsource a module, we should keep all the existing tests as they are in order to make sure that the API is not changed.

We should not evade the deprecation policy by outsourcing the package... the outsource packages should have the same quality standards as the Twisted project itself