Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#11715: Use NEXT in deprecation examples #11720

Merged
merged 2 commits into from Oct 26, 2022
Merged

#11715: Use NEXT in deprecation examples #11720

merged 2 commits into from Oct 26, 2022

Conversation

twm
Copy link
Contributor

@twm twm commented Oct 24, 2022

Fixes #11715.

@twm twm changed the title Use NEXT in deprecation examples #11715: Use NEXT in deprecation examples Oct 24, 2022
glyph
glyph approved these changes Oct 26, 2022
View reviewed changes
Copy link
Member

@glyph glyph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@twm twm enabled auto-merge October 26, 2022 05:49
@twm
Copy link
Contributor Author

twm commented Oct 26, 2022

Thanks for the review @glyph!

@adiroiban
Copy link
Member

Re-run the failed builds. They were failing due to the flaky asyncio reactor.

note, than unless a review is explicitly requested, I will consider the PR still WIP.

@twm twm merged commit 50761f4 into trunk Oct 26, 2022
@twm twm deleted the 11715-deprecated-next branch October 26, 2022 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glyph glyph glyph approved these changes

Assignees
No one assigned
Labels
needs-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

t.p.deprecate docs should show indeterminate versions
4 participants
@twm @adiroiban @glyph @chevah-robot