Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up twisted.trial.runner #11692

Closed
exarkun opened this issue Sep 26, 2022 · 0 comments · Fixed by #11693
Closed

Clean up twisted.trial.runner #11692

exarkun opened this issue Sep 26, 2022 · 0 comments · Fixed by #11693

Comments

@exarkun
Copy link
Member

exarkun commented Sep 26, 2022

Is your feature request related to a problem? Please describe.

twisted.trial.runner has some pretty cruft old stuff in it:

  • It has an implicit interface with debuggers
  • It manually implements resource allocation/cleanup for log files and the working directory
  • TrialRunner has a dozen or more attributes manually defined and of poorly document types
  • There are few type annotations
  • There is loooong-since deprecated support for reporters with no done method
  • The test suite involves monkey-patching implementation details to observe various side-effects
  • The test suite involves monkey-patching implementation details to fix unexplained bugs which apparently no longer exist

All of this stuff gets in the way of trying to implement new features like #11671 . Let's start to clean it up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant