Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary permissions in workflows #11631

Closed
sashashura opened this issue Sep 2, 2022 · 2 comments · Fixed by #11632
Closed

Remove unnecessary permissions in workflows #11631

sashashura opened this issue Sep 2, 2022 · 2 comments · Fixed by #11632
Labels

Comments

@sashashura
Copy link
Contributor

This is a security best practice because by default workflows run with extended set of permissions (except from on: pull_request from external forks). By specifying any permission explicitly all others are set to none. By using the principle of least privilege the damage a compromised workflow can do (because of an injection or compromised third party tool or action) is restricted.
It is recommended to have most strict permissions on the top level and grant write permissions on job level case by case.

@sashashura sashashura added the bug label Sep 2, 2022
@sashashura
Copy link
Contributor Author

#11632

@adiroiban
Copy link
Member

Thanks for your work.

Just a note.

If Fixes #1234 is added to the PR description, GitHub will automatically link back that PR.

it will also insert this under the issue title: May be fixed by #11632

image

The Fixes #1234 will also make sure that the issue is auto-closed when the PR is closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants