Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The test suite for worker result-reporting behavior involved in trial -j ... is unnecessarily complicated #11616

Closed
exarkun opened this issue Aug 25, 2022 · 0 comments · Fixed by #11617
Closed

The test suite for worker result-reporting behavior involved in trial -j ... is unnecessarily complicated #11616

exarkun opened this issue Aug 25, 2022 · 0 comments · Fixed by #11617
Labels
bug

Comments

@exarkun
Copy link
Member

exarkun commented Aug 25, 2022

The test suite is unnecessarily repetitive, it duplicates the implementation of certain protocol testing idioms, and it encodes implementation details instead of exercising the code under test in a realistic way.
@exarkun exarkun added the bug label Aug 25, 2022
This was referenced Aug 25, 2022
Merged
Closed
exarkun added a commit that referenced this issue Sep 7, 2022
@exarkun
#11616 disttrial worker test improvements (#11617)
2cb047b 
Some disttrial tests which previously depended on specific implementation details
of the local/worker protocol are now less dependent on those details.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#11616 disttrial worker test improvements exarkun/twisted
1 participant
@exarkun