Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GlibReactorBaseTests fails due to a typo #10317

Closed
twisted-trac opened this issue Mar 19, 2022 · 3 comments
Closed

GlibReactorBaseTests fails due to a typo #10317

twisted-trac opened this issue Mar 19, 2022 · 3 comments

Comments

@twisted-trac
Copy link

yan12125's avatar @yan12125 reported
Trac ID trac#10317
Type defect
Created 2022-03-19 07:25:09Z

On twisted trunk (f28b36d), GlibReactorBaseTests fails with:

$ PYTHONPATH="$PWD/src" python -c 'from twisted.scripts.trial import run; run()' twisted.internet.test.test_glibbase.GlibReactorBaseTests
twisted.internet.test.test_glibbase
  GlibReactorBaseTests
    test_simulate ...                                                   [ERROR]

===============================================================================
[ERROR]
Traceback (most recent call last):
  File "/home/yen/tmp/twisted/src/twisted/internet/test/test_glibbase.py", line 96, in test_simulate
    sut = gireactor.PortableGIReactor(usegtk=False)
builtins.TypeError: PortableGIReactor.__init__() got an unexpected keyword argument 'usegtk'

twisted.internet.test.test_glibbase.GlibReactorBaseTests.test_simulate
-------------------------------------------------------------------------------
Ran 1 tests in 0.002s

FAILED (errors=1)

That's because of a typo - usegtk should be useGtk

Searchable metadata
trac-id__10317 10317
type__defect defect
reporter__yan12125 yan12125
priority__normal normal
milestone__None None
branch__ 
branch_author__ 
status__closed closed
resolution__fixed fixed
component__core core
keywords__None None
time__1647674709265390 1647674709265390
changetime__1648905098087375 1648905098087375
version__None None
owner__None None

@twisted-trac
Copy link
Author

yan12125's avatar @yan12125 commented

Here is the fix: #1706

@twisted-trac
Copy link
Author

exarkun's avatar @exarkun commented

Approved

@twisted-trac
Copy link
Author

yan12125's avatar @yan12125 set status to closed

Pull request merged - thanks for kind review and help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant