We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#1678 became a problem because the relevant test cases were skipped on all platforms due to code with this pattern:
if hasTheThing: skipFoo = "" # Intent: don't skip else: skipFoo = "don't have the thing" class FooTests(TestCase): skip = skipFoo ...
However, the empty string here still skips. None is the sentinel value to not skip. There are a bunch of places this pattern appears in the codebase.
None
trac-id__10292 10292 type__defect defect reporter__twm twm priority__high high milestone__None None branch__10292_bad_skips 10292-bad-skips branch_author__ status__closed closed resolution__fixed fixed component__core core keywords__None None time__1642390087277284 1642390087277284 changetime__1642571034521966 1642571034521966 version__None None owner__twm twm
The text was updated successfully, but these errors were encountered:
assigned
Sorry, something went wrong.
#1682
new
closed
Merged: 7039a20
Thanks for the review Glyph!
twm
No branches or pull requests
#1678 became a problem because the relevant test cases were skipped on all platforms due to code with this pattern:
However, the empty string here still skips.
None
is the sentinel value to not skip. There are a bunch of places this pattern appears in the codebase.Searchable metadata
The text was updated successfully, but these errors were encountered: