Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

assertFullyNewStyle is no longer useful #10277

Closed
twisted-trac opened this issue Nov 17, 2021 · 3 comments
Closed

assertFullyNewStyle is no longer useful #10277

twisted-trac opened this issue Nov 17, 2021 · 3 comments
Assignees
@wsanchez
Labels
core enhancement new priority-normal

Comments

@twisted-trac
Copy link

wsanchez's avatar @wsanchez reported
Trac ID trac#10277
Type enhancement
Created 2021-11-17 07:42:59Z

src/twisted/internet/test/test_core.py has an assertFullyNewStyle that will never raise in Py3.

See #1598 (review)

Searchable metadata 
trac-id__10277 10277
type__enhancement enhancement
reporter__wsanchez wsanchez
priority__normal normal
milestone__None None
branch__ 
branch_author__ 
status__new new
resolution__None None
component__core core
keywords__None None
time__1637134979278613 1637134979278613
changetime__1640654197521599 1640654197521599
version__None None
owner__wsanchez wsanchez
cc__graingert
@twisted-trac
Copy link
Author

wsanchez's avatar @wsanchez commented

#1673

@twisted-trac
Copy link
Author

twm's avatar @twm set owner to @wsanchez

Adi reviewed. This is good to merge.

@adiroiban
Copy link
Member

closed in #1673

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wsanchez wsanchez

Labels
core enhancement new priority-normal
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@wsanchez @adiroiban @twisted-trac