IReactorSSL.listenSSL has wrong return type

[twisted-trac]

	@clokep reported
Trac ID	trac#10274
Type	defect
Created	2021-11-10 13:34:16Z

IReactorSSL.listenSSL is defined as returning an int, this is incorrect and it should return an IListeningPort instance, similar to IReactorTCP.listenTCP.

IReactorSSL has three implementors:

• PosixReactorBase: this returns an instance of tcp.Port or ssl.Port (which is a simple subclass of tcp.Port.
• MemoryReactor: this returns an instance of _FakePort.
• RaisingMemoryReactor: this raise an exception

This was found while adding type hints to Synapse: matrix-org/synapse#11287; I'll attempt to put up a pull request later today.

Searchable metadata

trac-id__10274 10274
type__defect defect
reporter__clokep clokep
priority__low low
milestone__None None
branch__ 
branch_author__ 
status__closed closed
resolution__fixed fixed
component__core core
keywords__None None
time__1636551256075533 1636551256075533
changetime__1646513339913958 1646513339913958
version__None None
owner__None None

[twisted-trac]

	@clokep commented

Fix is at #1672

[twisted-trac]

	@twm set status to closed

Approved and queued for merge. Thank you for making the review easy!