Add type hints for twisted.internet.task

[twisted-trac]

	@wsanchez reported
Trac ID	trac#10155
Type	enhancement
Created	2021-03-27 19:35:26Z
Branch	https://github.com/twisted/twisted/tree/1570

Add type hints for twisted.internet.task

Searchable metadata

trac-id__10155 10155
type__enhancement enhancement
reporter__wsanchez wsanchez
priority__normal normal
milestone__None None
branch__1570 1570
branch_author__ 
status__reopened reopened
resolution__None None
component__core core
keywords__None None
time__1616873726559072 1616873726559072
changetime__1627055790806379 1627055790806379
version__None None
owner__wsanchez wsanchez

[twisted-trac]

	@wsanchez commented

PR: #1570

[twisted-trac]

	@wsanchez set owner to @wsanchez

[twisted-trac]

	@wsanchez set status to closed

[twisted-trac]

	@adiroiban set status to reopened

Was reverted due to #10235

[twisted-trac]

	@wsanchez commented

Just to clarify… it looks like #10235 was addressed by PR 1367, which reverted part of this ticket, but not all of it.

In particular, it reverts a change related to the use of the now built into supported Python's __qualname__ attribute on callables, because Python only provides that for functions, and so callables like classes broke.

Jonathan de Jong comments in the PR that this is easily fixed for classes. That comment wasn't replied to prior to merging, perhaps because this was just being done to get the release moving.

All that said, this was an opportunistic cleanup of code, and the rest of this ticket was left intact, I'm inclined to close this again. Sound right?

[exarkun]

The DelayedCall __repr__ changes don't seem strongly related to the task of "Add type hints for twisted.internet.task" so I am closing this again.

#6066 which was closed on the basis of exactly the reverted revision should still be open, though, and I have re-opened it since it was left closed.