Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump python_requires to 3.5.3 for typing.Type #10098

Closed
twisted-trac opened this issue Feb 25, 2021 · 2 comments
Closed

Bump python_requires to 3.5.3 for typing.Type #10098

twisted-trac opened this issue Feb 25, 2021 · 2 comments

Comments

@twisted-trac
Copy link

graingert's avatar @graingert reported
Trac ID trac#10098
Type enhancement
Created 2021-02-25 21:53:41Z

fixed in python 3.5.3 python/typing#267

(env3)rav at faith:~$ python3
Python 3.5.2 (default, Oct  7 2020, 17:19:02)
[GCC 5.4.0 20160609] on linux
Type "help", "copyright", "credits" or "license" for more information.
 >>> from twisted.python import log
Traceback (most recent call last):
   File "<stdin>", line 1, in <module>
   File 
"/home/synapse/env3/lib/python3.5/site-packages/twisted/python/log.py", 
line 20, in <module>
     from twisted.python import reflect
   File 
"/home/synapse/env3/lib/python3.5/site-packages/twisted/python/reflect.py", 
line 377, in <module>
     def _safeFormat(formatter: Union[types.FunctionType, Type[str]], o: 
object) -> str:
   File "/usr/lib/python3.5/typing.py", line 552, in __getitem__
     dict(self.__dict__), parameters, _root=True)
   File "/usr/lib/python3.5/typing.py", line 512, in __new__
     for t2 in all_params - {t1} if not isinstance(t2, TypeVar)):
   File "/usr/lib/python3.5/typing.py", line 512, in <genexpr>
     for t2 in all_params - {t1} if not isinstance(t2, TypeVar)):
   File "/usr/lib/python3.5/typing.py", line 1077, in __subclasscheck__
     if super().__subclasscheck__(cls):
   File "/usr/lib/python3.5/abc.py", line 225, in __subclasscheck__
     for scls in cls.__subclasses__():
TypeError: descriptor '__subclasses__' of 'type' object needs an argument

#1524

Searchable metadata
trac-id__10098 10098
type__enhancement enhancement
reporter__graingert graingert
priority__normal normal
milestone__None None
branch__ 
branch_author__ 
status__closed closed
resolution__fixed fixed
component__core core
keywords__review review
time__1614290021714800 1614290021714800
changetime__1614536347034081 1614536347034081
version__None None
owner__None None

@twisted-trac
Copy link
Author

graingert's avatar @graingert commented

#1524

@twisted-trac
Copy link
Author

rodrigc's avatar @rodrigc set status to closed

This has been merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant